public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Greg Kroah-Hartman <gregkh@suse.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, Thomas Renninger <trenn@suse.de>,
	Andi Kleen <ak@linux.intel.com>,
	linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
	linux-pm@vger.kernel.org
Subject: [PATCH 4/5] intel_idle: Revert change of auto_demotion_flags for Nehalem
Date: Sat, 11 Feb 2012 22:55:10 +0000	[thread overview]
Message-ID: <1329000910.325.55.camel@deadeye> (raw)
In-Reply-To: <1329000256.325.48.camel@deadeye>

Commit b66b8b9a4a79087dde1b358a016e5c8739ccf186 ('intel-idle: convert
to x86_cpu_id auto probing') added a distinction between Nehalem and
Westemere processors and changed auto_demotion_flags for the former to
0.  This was not explained in the commit message, so change it back.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
I have very little idea what I'm doing here...

Ben.

 drivers/idle/intel_idle.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index a238649..1c15e9b 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -331,10 +331,6 @@ static void auto_demotion_disable(void *dummy)
 
 static const struct idle_cpu idle_cpu_nehalem = {
 	.state_table = nehalem_cstates,
-};
-
-static const struct idle_cpu idle_cpu_westmere = {
-	.state_table = nehalem_cstates,
 	.auto_demotion_disable_flags = NHM_C1_AUTO_DEMOTE | NHM_C3_AUTO_DEMOTE,
 };
 
@@ -358,12 +354,12 @@ static const struct x86_cpu_id intel_idle_ids[] = {
 	ICPU(0x1a, idle_cpu_nehalem),
 	ICPU(0x1e, idle_cpu_nehalem),
 	ICPU(0x1f, idle_cpu_nehalem),
-	ICPU(0x25, idle_cpu_westmere),
-	ICPU(0x2c, idle_cpu_westmere),
-	ICPU(0x2e, idle_cpu_westmere),
+	ICPU(0x25, idle_cpu_nehalem),
+	ICPU(0x2c, idle_cpu_nehalem),
+	ICPU(0x2e, idle_cpu_nehalem),
 	ICPU(0x1c, idle_cpu_atom),
 	ICPU(0x26, idle_cpu_lincroft),
-	ICPU(0x2f, idle_cpu_westmere),
+	ICPU(0x2f, idle_cpu_nehalem),
 	ICPU(0x2a, idle_cpu_snb),
 	ICPU(0x2d, idle_cpu_snb),
 	{}
-- 
1.7.9




  parent reply	other threads:[~2012-02-11 22:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-11 22:44 [PATCH 0/5] Clean up x86 CPU auto-loading Ben Hutchings
2012-02-11 22:46 ` [PATCH 1/5] x86/cpu: Fix overrun check in arch_print_cpu_modalias() Ben Hutchings
2012-02-11 22:52 ` [PATCH 2/5] x86/cpu: Clean up modalias feature matching Ben Hutchings
2012-02-11 22:54 ` [PATCH 3/5] intel_idle: Fix ID for Nehalem-EX Xeon in device ID table Ben Hutchings
2012-02-11 22:55 ` Ben Hutchings [this message]
2012-02-12 17:10   ` [PATCH 4/5] intel_idle: Revert change of auto_demotion_flags for Nehalem Thomas Renninger
2012-02-11 22:55 ` [PATCH 5/5] powernow-k7: Fix CPU family number Ben Hutchings
2012-02-12 23:10 ` [PATCH 0/5] Clean up x86 CPU auto-loading Thomas Renninger
2012-02-13  1:26   ` H. Peter Anvin
2012-02-13 22:26     ` Greg KH
2012-02-13 22:55       ` H. Peter Anvin
2012-02-13  2:18   ` Greg KH
2012-02-13  3:00     ` H. Peter Anvin
2012-02-13  6:43       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329000910.325.55.camel@deadeye \
    --to=ben@decadent.org.uk \
    --cc=ak@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=trenn@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox