From: Luciano Coelho <coelho@ti.com>
To: Ben Dooks <ben-i2c@fluff.org>
Cc: linux-i2c@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, tony@atomide.com,
khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de,
grant.likely@secretlab.ca, rob.herring@calxeda.com,
devicetree-discuss@lists.ozlabs.org,
Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set
Date: Tue, 14 Feb 2012 11:55:31 +0200 [thread overview]
Message-ID: <1329213331.3032.62.camel@cumari> (raw)
In-Reply-To: <20120213232707.GH2999@freya.fluff.org>
Hi Ben,
On Mon, 2012-02-13 at 23:27 +0000, Ben Dooks wrote:
> On Wed, Feb 08, 2012 at 01:18:21PM +0200, Luciano Coelho wrote:
> > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> > index f713eac..fd200eb 100644
> > --- a/drivers/i2c/busses/i2c-omap.c
> > +++ b/drivers/i2c/busses/i2c-omap.c
> > @@ -979,6 +979,8 @@ static const struct of_device_id omap_i2c_of_match[] = {
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, omap_i2c_of_match);
> > +#else
> > +static const struct of_device_id *omap_i2c_of_match = NULL;
> > #endif
>
> of_match_ptr(_ptr) will go to NULL if CONFIG_OF is not set, use that please.
Yes, you're right. But this patch can be ignored, since there was
already an equivalent one queued up (which I missed). And it uses
of_match_ptr() ;)
Thanks for your comment anyway!
--
Cheers,
Luca.
prev parent reply other threads:[~2012-02-14 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 11:18 [PATCH 3.3 v2] I2C: OMAP: fix build breakage when CONFIG_OF is not set Luciano Coelho
2012-02-13 23:27 ` Ben Dooks
2012-02-14 9:55 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329213331.3032.62.camel@cumari \
--to=coelho@ti.com \
--cc=b-cousson@ti.com \
--cc=ben-i2c@fluff.org \
--cc=ben-linux@fluff.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox