From: Chris Boot <bootc@bootc.net>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] firewire-sbp2: Various fixes
Date: Wed, 15 Feb 2012 14:59:07 +0000 [thread overview]
Message-ID: <1329317950-101579-1-git-send-email-bootc@bootc.net> (raw)
In-Reply-To: <1328881314-26544-1-git-send-email-bootc@bootc.net>
In writing my SBP-2 target code I found a few areas in the firewire-sbp2
initiator code that needed some attention:
1. The Unit_Unique_ID property in SBP-2 unit directories is ignored, but this
should be used when working out the target port name instead of the node's
GUID if it is present. (Suggestion of Stefan Richter)
2. The initiator tries to login to any and all SBP-2 targets, including ones on
the local node. This fails due to how the firewire stack / initiator code
works but is most likely undesirable behaviour, so this patch makes
firewire-sbp2 ignore SBP-2 targets on the local node.
3. SBP-2 sends SCSI sense data over the wire in an unusual format which
requires un-mangling before we can pass it to the SCSI subsystem. Some of
this mangling is currently being done incorrectly, so this patch fixes it.
Changes since v1:
* Don't fail on malformed Unit_Unique_ID properties, just ignore them
* Just return -ENODEV when we encounter the local node
next prev parent reply other threads:[~2012-02-15 14:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EE1CAC85-DF0C-4C21-B2BD-446C481C938F@bootc.net>
2012-02-10 13:41 ` [PATCH 0/3] firewire-sbp2: Various fixes Chris Boot
2012-02-10 13:41 ` [PATCH 1/3] firewire-sbp2: Take into account Unit_Unique_ID Chris Boot
2012-02-11 11:12 ` Stefan Richter
2012-02-11 12:26 ` Chris Boot
2012-02-11 13:06 ` Stefan Richter
2012-02-10 13:41 ` [PATCH 2/3] firewire-sbp2: Ignore SBP-2 targets on the local node Chris Boot
2012-02-11 11:28 ` Stefan Richter
2012-02-11 12:16 ` Clemens Ladisch
2012-02-11 12:31 ` Chris Boot
2012-02-11 15:46 ` Clemens Ladisch
2012-02-11 15:49 ` Chris Boot
2012-02-11 11:56 ` Stefan Richter
2012-02-11 12:32 ` Chris Boot
2012-02-10 13:41 ` [PATCH 3/3] firewire-sbp2: Fix SCSI sense data mangling Chris Boot
2012-02-15 14:59 ` Chris Boot [this message]
2012-02-15 14:59 ` [PATCH v2 1/3] firewire-sbp2: Take into account Unit_Unique_ID Chris Boot
2012-02-15 14:59 ` [PATCH v2 2/3] firewire-sbp2: Ignore SBP-2 targets on the local node Chris Boot
2012-02-15 14:59 ` [PATCH v2 3/3] firewire-sbp2: Fix SCSI sense data mangling Chris Boot
2012-02-22 22:17 ` [PATCH v2 0/3] firewire-sbp2: Various fixes Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329317950-101579-1-git-send-email-bootc@bootc.net \
--to=bootc@bootc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).