From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, vgoyal@redhat.com
Cc: ctalbott@google.com, rni@google.com, linux-kernel@vger.kernel.org
Subject: [PATCHSET] blkcg: update locking and fix stacking
Date: Thu, 16 Feb 2012 14:37:49 -0800 [thread overview]
Message-ID: <1329431878-28300-1-git-send-email-tj@kernel.org> (raw)
Hey, guys.
This is the third patchset of blkcg API cleanup series and does the
following two things.
* Drops RCU and use double locking. As with ioc, we might want to
re-introduce RCU in more restricted form to walk blkg from blkcg but
for now there's no need. cgroup deletion is much colder than task
exit and there's no other path which requires reverse double
locking.
* Before this patchset, blk-throttle and cfq-iosched propio couldn't
be used together because for any bios delayed by blk-throttle would
be issued by a worker thread and get dumped to the default cgroup.
So, bios will be nondeterministically thrown into the root cg. This
isn't a problem limited to blk-throttle. Any mechanism which punts
bios to a different task (e.g. btrfs) would mess up IO scheduling
for both cgroups and iocontexts.
This patchset implements a mechanism to associate a bio to a task
(its cgroup and ioc actually) and block layer will handle the
request as if it were issued by the associated task no matter which
task actually ends up issuing it to block layer. It's applied to
blk-throttle such that any delayed bio is associated to the original
task.
This patchset contains the following 9 patches.
0001-blkcg-use-double-locking-instead-of-RCU-for-blkg-syn.patch
0002-blkcg-drop-unnecessary-RCU-locking.patch
0003-block-restructure-get_request.patch
0004-block-interface-update-for-ioc-icq-creation-function.patch
0005-block-ioc_task_link-can-t-fail.patch
0006-block-add-io_context-active_ref.patch
0007-block-implement-bio_associate_current.patch
0008-block-make-block-cgroup-policies-follow-bio-task-ass.patch
0009-block-make-blk-throttle-preserve-the-issuing-task-on.patch
0001-0002 updates locking and strips out RCU.
0003-0006 prepare for bio task association.
0007-0009 implement bio task association and apply it to
blk-throttle.
This patchset is on top of
block/for-linus 621032ad6eaabf2fe771c4fa0d8f58e1fcfcdba6
+ [1] blkcg: kill policy node and blkg->dev, take#4
+ [2] blkcg: unify blkgs for different policies (updated)
and is also available in the following git branch.
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blkcg-locking
The git branch has separate branches for previous patchsets, so using
it probably is the easiest way to review this series. Jens, if you
want the whole thing reposted, please let me know.
diffstat follows.
block/blk-cgroup.c | 167 +++++++++++++++++-----------------------------
block/blk-cgroup.h | 12 +--
block/blk-core.c | 92 ++++++++++++++-----------
block/blk-ioc.c | 58 +++++++++------
block/blk-throttle.c | 41 +----------
block/blk.h | 24 +++---
block/cfq-iosched.c | 54 ++++----------
block/cfq.h | 10 --
block/elevator.c | 5 -
fs/bio.c | 61 ++++++++++++++++
include/linux/bio.h | 8 ++
include/linux/blk_types.h | 10 ++
include/linux/blkdev.h | 1
include/linux/elevator.h | 6 +
include/linux/iocontext.h | 32 ++++++--
kernel/fork.c | 5 -
16 files changed, 299 insertions(+), 287 deletions(-)
Thanks.
--
tejun
[1] http://thread.gmane.org/gmane.linux.kernel/1247152
[2] http://thread.gmane.org/gmane.linux.kernel/1247287
next reply other threads:[~2012-02-16 22:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 22:37 Tejun Heo [this message]
2012-02-16 22:37 ` [PATCH 1/9] blkcg: use double locking instead of RCU for blkg synchronization Tejun Heo
2012-02-16 22:37 ` [PATCH 2/9] blkcg: drop unnecessary RCU locking Tejun Heo
2012-02-17 16:19 ` Vivek Goyal
2012-02-17 17:07 ` Tejun Heo
2012-02-17 17:14 ` Tejun Heo
2012-02-17 16:47 ` Vivek Goyal
2012-02-17 17:11 ` Tejun Heo
2012-02-17 17:28 ` Vivek Goyal
2012-02-17 17:43 ` Tejun Heo
2012-02-17 18:08 ` Vivek Goyal
2012-02-17 18:16 ` Tejun Heo
2012-02-22 0:49 ` [PATCH UPDATED " Tejun Heo
2012-02-16 22:37 ` [PATCH 3/9] block: restructure get_request() Tejun Heo
2012-02-16 22:37 ` [PATCH 4/9] block: interface update for ioc/icq creation functions Tejun Heo
2012-02-16 22:37 ` [PATCH 5/9] block: ioc_task_link() can't fail Tejun Heo
2012-02-17 20:41 ` Vivek Goyal
2012-02-17 22:18 ` Tejun Heo
2012-02-16 22:37 ` [PATCH 6/9] block: add io_context->active_ref Tejun Heo
2012-02-16 22:37 ` [PATCH 7/9] block: implement bio_associate_current() Tejun Heo
2012-02-17 1:19 ` Kent Overstreet
2012-02-17 22:14 ` Tejun Heo
2012-02-17 22:34 ` Vivek Goyal
2012-02-17 22:41 ` Tejun Heo
2012-02-17 22:51 ` Vivek Goyal
2012-02-17 22:57 ` Tejun Heo
2012-02-20 14:22 ` Vivek Goyal
2012-02-20 16:59 ` Tejun Heo
2012-02-20 19:14 ` Vivek Goyal
2012-02-20 21:21 ` Tejun Heo
2012-02-27 23:12 ` Chris Wright
2012-02-28 14:10 ` Vivek Goyal
2012-02-28 17:01 ` Chris Wright
2012-02-28 20:11 ` Stefan Hajnoczi
2012-02-20 14:36 ` Vivek Goyal
2012-02-20 17:01 ` Tejun Heo
2012-02-20 19:16 ` Vivek Goyal
2012-02-20 21:06 ` Tejun Heo
2012-02-20 21:10 ` Vivek Goyal
2012-02-17 22:56 ` Vivek Goyal
2012-02-17 23:06 ` Tejun Heo
2012-02-17 21:33 ` Vivek Goyal
2012-02-17 22:03 ` Tejun Heo
2012-02-17 22:29 ` Vivek Goyal
2012-02-17 22:38 ` Tejun Heo
2012-02-17 22:42 ` Tejun Heo
2012-02-16 22:37 ` [PATCH 8/9] block: make block cgroup policies follow bio task association Tejun Heo
2012-02-16 22:37 ` [PATCH 9/9] block: make blk-throttle preserve the issuing task on delayed bios Tejun Heo
2012-02-17 21:58 ` Vivek Goyal
2012-02-17 22:17 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329431878-28300-1-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).