From: Peter Zijlstra <peterz@infradead.org>
To: Paul Turner <pjt@google.com>
Cc: Venkatesh Pallipadi <venki@google.com>,
Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] sched: Optimize cgroup pick_next_task_fair
Date: Fri, 17 Feb 2012 00:28:20 +0100 [thread overview]
Message-ID: <1329434900.2293.261.camel@twins> (raw)
In-Reply-To: <1329434437.2293.259.camel@twins>
On Fri, 2012-02-17 at 00:20 +0100, Peter Zijlstra wrote:
> + if (prev && (prev->sched_class != &fair_sched_class ||
> + cfs_rq->nr_running == 1)) {
this ==1 check is way ugly and a problem that needs addressing. Not
putting cfs_rq->curr back in the tree perturbs pick_next_entity()'s view
of things.
Probably easiest to pick leftmost and ->curr and go from there, but
that's for tomorrow or so.
next prev parent reply other threads:[~2012-02-16 23:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 5:05 [RFC][PATCH] sched: Optimize cgroup pick_next_task_fair Peter Zijlstra
2012-02-11 6:56 ` Mike Galbraith
2012-02-11 15:02 ` Peter Zijlstra
2012-02-16 23:20 ` Peter Zijlstra
2012-02-16 23:28 ` Peter Zijlstra [this message]
2014-02-11 12:16 ` [tip:sched/core] sched/fair: Track cgroup depth tip-bot for Peter Zijlstra
2014-02-11 12:16 ` [tip:sched/core] sched: Push put_prev_task() into pick_next_task( ) tip-bot for Peter Zijlstra
2014-02-12 7:00 ` Kirill Tkhai
2014-02-12 11:43 ` Peter Zijlstra
2014-02-12 14:06 ` Peter Zijlstra
2014-02-12 14:24 ` Kirill Tkhai
2014-02-12 14:54 ` Peter Zijlstra
2014-02-11 12:16 ` [tip:sched/core] sched/fair: Clean up the __clear_buddies_*() functions tip-bot for Peter Zijlstra
2014-02-11 12:16 ` [tip:sched/core] sched/fair: Optimize cgroup pick_next_task_fair( ) tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329434900.2293.261.camel@twins \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjt@google.com \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox