From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755271Ab2BQX1s (ORCPT ); Fri, 17 Feb 2012 18:27:48 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:44108 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753333Ab2BQX1r (ORCPT ); Fri, 17 Feb 2012 18:27:47 -0500 Message-ID: <1329521263.584.50.camel@joe2Laptop> Subject: Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin From: Joe Perches To: Mike Frysinger Cc: Danny Kukawka , "David S. Miller" , Sonic Zhang , Jeff Kirsher , Bob Liu , uclinux-dist-devel@blackfin.uclinux.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2012 15:27:43 -0800 In-Reply-To: <201202171815.59846.vapier@gentoo.org> References: <1329412171-20704-1-git-send-email-danny.kukawka@bisect.de> <201202171157.55585.danny.kukawka@bisect.de> <201202171815.59846.vapier@gentoo.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-02-17 at 18:15 -0500, Mike Frysinger wrote: > On Friday 17 February 2012 05:57:54 Danny Kukawka wrote: > > Maybe. Many drivers already print information about setting a random mac > > address to a netdevice. Some with printk, some via > > netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum > > methods. I could unify this, in a next step with a netdev_info in > > eth_hw_addr_random(), if it's okay for David. > i think unification in the core makes sense. it enforces consistency and > removes duplication. It's a good idea.