From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186Ab2BRGa3 (ORCPT ); Sat, 18 Feb 2012 01:30:29 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:49439 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751932Ab2BRGa2 (ORCPT ); Sat, 18 Feb 2012 01:30:28 -0500 Message-ID: <1329546625.1753.7.camel@joe2Laptop> Subject: Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err From: Joe Perches To: Dan Carpenter Cc: Jorgyano Vieira , gregkh@linuxfoundation.org, devel@linuxdriverproject.org, jarod@wilsonet.com, nsankar@broadcom.com, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2012 22:30:25 -0800 In-Reply-To: <20120218062534.GB2855@mwanda> References: <1329521976-1326-1-git-send-email-jorgyano@gmail.com> <20120218062534.GB2855@mwanda> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote: > On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote: > > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition. > This needs a pr_fmt line so we can tell where the errors are coming > from. > #define pr_fmt(fmt) KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__ True. __func__ and __LINE__ are not generally useful though. I suggest just #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt