From: Joe Perches <joe@perches.com>
To: Jorgyano vieira <jorgyano@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, nsankar@broadcom.com,
jarod@wilsonet.com
Subject: Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
Date: Sat, 18 Feb 2012 15:14:37 -0800 [thread overview]
Message-ID: <1329606877.1753.37.camel@joe2Laptop> (raw)
In-Reply-To: <CABRD5hKU0a-z8qd+xQEcHzH3y3eFy+sxUUtg1NXi+fqmbw4h4A@mail.gmail.com>
On Sat, 2012-02-18 at 21:08 -0200, Jorgyano vieira wrote:
> > o pr_fmt needs to be #defined before any #include that might
> > directly or indirectly #include kernel.h/printk.h
> > use 'strings <path>/built-in.o | grep "^<.>"' to verify.
> yes, I take care of this:--- a/drivers/staging/crystalhd/crystalhd_misc.h
> +++ b/drivers/staging/crystalhd/crystalhd_misc.h
> @@ -28,6 +28,8 @@
> #ifndef _CRYSTALHD_MISC_H_
> #define _CRYSTALHD_MISC_H_
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
Maybe.
$ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include" drivers/staging/crystalhd/
drivers/staging/crystalhd/crystalhd_cmds.h:#include "crystalhd_misc.h"
drivers/staging/crystalhd/crystalhd_lnx.c:#include <linux/mutex.h>
drivers/staging/crystalhd/crystalhd_cmds.c:#include "crystalhd_cmds.h"
drivers/staging/crystalhd/bc_dts_types.h:#include <stdint.h>
drivers/staging/crystalhd/bc_dts_glob_lnx.h:#include <stdio.h>
drivers/staging/crystalhd/crystalhd_misc.c:#include <linux/slab.h>
drivers/staging/crystalhd/crystalhd_misc.h:#include <linux/module.h>
drivers/staging/crystalhd/crystalhd_lnx.h:#include <linux/module.h>
drivers/staging/crystalhd/crystalhd_hw.h:#include "crystalhd_misc.h"
drivers/staging/crystalhd/crystalhd_hw.c:#include <linux/pci.h>
so lnx, cmds, misc, and hw.c are/were suspect.
cheers, Joe
next prev parent reply other threads:[~2012-02-18 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-18 22:10 [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err Jorgyano Vieira
2012-02-18 22:31 ` Joe Perches
2012-02-18 23:08 ` Jorgyano vieira
2012-02-18 23:14 ` Joe Perches [this message]
2012-02-18 23:34 ` Jorgyano vieira
2012-02-18 23:45 ` Joe Perches
2012-02-24 19:49 ` Greg KH
2012-02-25 5:23 ` Jorgyano vieira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329606877.1753.37.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarod@wilsonet.com \
--cc=jorgyano@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsankar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox