From: Ashish Jangam <ashish.jangam@kpitcummins.com>
To: <broonie@opensource.wolfsonmicro.com>
Cc: <arnd@arndb.de>, <sameo@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <dajun.chen@diasemi.com>
Subject: Re: [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD core v2
Date: Tue, 21 Feb 2012 17:01:37 +0530 [thread overview]
Message-ID: <1329823897.30549.175.camel@dhruva> (raw)
In-Reply-To: <C3AE124F08223B42BC95AEB82F0F6CED2B996CCD@KCHJEXMB01.kpit.com>
> On Mon, Feb 20, 2012 at 12:07:27PM +0000, Arnd Bergmann wrote:
>
> > Also, I would recommend using request_irq instead of
> > request_threaded_irq here because the function only has a single
> > "complete()" call in it, just like a threaded IRQ handler has. There
> > is no point going through another thread just to wake up the one that is blocked.
>
> Actually in this case that won't work as the interrupt is generated by the chip interrupt controller and as the chip is I2C/SPI controlled it is itself threaded and can only generate threaded interrupts as genirq can't get back into hard interrupt context.
>
> As a result of this restriction when an interrupt handler doesn't care what context it runs in it's better to use request_any_context_irq().
> This will do a normal IRQ when it can but will bind successfully to a threaded IRQ if that's what's provided.
as threaded IRQs are only being used, request_any_context_irq() will
internally call request_threaded_irq() so is there any other need to
replace the current request_threaded_irq()?
next parent reply other threads:[~2012-02-21 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C3AE124F08223B42BC95AEB82F0F6CED2B996CCD@KCHJEXMB01.kpit.com>
2012-02-21 11:31 ` Ashish Jangam [this message]
2012-02-21 12:04 ` [PATCH 01/01] MFD: add ADC support to DA9052/53 MFD core v2 Arnd Bergmann
2012-01-13 14:30 Ashish Jangam
2012-02-20 11:44 ` Samuel Ortiz
2012-02-20 12:07 ` Arnd Bergmann
2012-02-20 15:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329823897.30549.175.camel@dhruva \
--to=ashish.jangam@kpitcummins.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dajun.chen@diasemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox