* [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages
@ 2012-02-21 14:51 Fabio Estevam
2012-03-06 11:31 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2012-02-21 14:51 UTC (permalink / raw)
To: linux-kernel; +Cc: vinod.koul, dan.j.williams, Fabio Estevam, Fabio Estevam
The message "dmaengine: failed to get" can come from two possible locations within dmaengine.c.
In order to distinguish between them, replace "dmaengine" with __func__ string so that the
source function of the error message can be easily identified.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/dmaengine.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index a6c6051..ac10325 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma/dmaengine.c
@@ -510,8 +510,8 @@ struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, dma_filter_fn fn, v
dma_chan_name(chan));
list_del_rcu(&device->global_node);
} else if (err)
- pr_debug("dmaengine: failed to get %s: (%d)\n",
- dma_chan_name(chan), err);
+ pr_debug("%s: failed to get %s: (%d)\n",
+ __func__, dma_chan_name(chan), err);
else
break;
if (--device->privatecnt == 0)
@@ -564,8 +564,8 @@ void dmaengine_get(void)
list_del_rcu(&device->global_node);
break;
} else if (err)
- pr_err("dmaengine: failed to get %s: (%d)\n",
- dma_chan_name(chan), err);
+ pr_err("%s: failed to get %s: (%d)\n",
+ __func__, dma_chan_name(chan), err);
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages
2012-02-21 14:51 [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages Fabio Estevam
@ 2012-03-06 11:31 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2012-03-06 11:31 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-kernel, dan.j.williams, Fabio Estevam
On Tue, 2012-02-21 at 12:51 -0200, Fabio Estevam wrote:
> The message "dmaengine: failed to get" can come from two possible locations within dmaengine.c.
>
> In order to distinguish between them, replace "dmaengine" with __func__ string so that the
> source function of the error message can be easily identified.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/dma/dmaengine.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
> index a6c6051..ac10325 100644
> --- a/drivers/dma/dmaengine.c
> +++ b/drivers/dma/dmaengine.c
> @@ -510,8 +510,8 @@ struct dma_chan *__dma_request_channel(dma_cap_mask_t *mask, dma_filter_fn fn, v
> dma_chan_name(chan));
> list_del_rcu(&device->global_node);
> } else if (err)
> - pr_debug("dmaengine: failed to get %s: (%d)\n",
> - dma_chan_name(chan), err);
> + pr_debug("%s: failed to get %s: (%d)\n",
> + __func__, dma_chan_name(chan), err);
> else
> break;
> if (--device->privatecnt == 0)
> @@ -564,8 +564,8 @@ void dmaengine_get(void)
> list_del_rcu(&device->global_node);
> break;
> } else if (err)
> - pr_err("dmaengine: failed to get %s: (%d)\n",
> - dma_chan_name(chan), err);
> + pr_err("%s: failed to get %s: (%d)\n",
> + __func__, dma_chan_name(chan), err);
> }
> }
>
Applied, Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-06 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-21 14:51 [PATCH] dma: dmaengine: Distinguish between 'dmaengine: failed to get' messages Fabio Estevam
2012-03-06 11:31 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox