From: Thomas Meyer <thomas@m3y3r.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ian Kent <raven@themaw.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 3.3-rc4
Date: Tue, 21 Feb 2012 19:58:34 +0100 [thread overview]
Message-ID: <1329850714.1419.2.camel@localhost.localdomain> (raw)
In-Reply-To: <CA+55aFzUWDEuj85sOKjwk8ufy+1rbS7hgstw0cCWpjTgu=7B4A@mail.gmail.com>
Am Sonntag, den 19.02.2012, 10:45 -0800 schrieb Linus Torvalds:
> On Sun, Feb 19, 2012 at 5:42 AM, Thomas Meyer <thomas@m3y3r.de> wrote:
> >
> > 1.) autofs4 interface is broken between x86 and x86_64. as systemd uses autofs, this bug hangs the boot process as e.g. binfmt is mounted via autofs. see also http://lists.freedesktop.org/archives/systemd-devel/2011-September/003396.html
>
> Duh.
>
> That is just broken.
>
> The code even *talks* about how the packet layout is the same on
> 32-bit and 64-bit architectures, and that's largely true.
>
> However, while true, x86-64 has 8-byte alignment for 'long', and
> x86-32 has 4-byte alignment. Which means that even though the
> structure layout is exactly the same, on x86-64 the *alignment* issue
> will push it out to 304 bytes.
>
> That's just stupid. We've had that problem before. It's easy to
> overlook, but that packet is just mis-designed.
>
> The attached patch isn't pretty, but this is definitely a kernel bug.
> Binary compatibility is *important*, dammit.
>
> Does this fix it?
yes, it does!
thanks.
next prev parent reply other threads:[~2012-02-21 18:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 0:27 Linux 3.3-rc4 Linus Torvalds
2012-02-19 13:42 ` Thomas Meyer
2012-02-19 18:45 ` Linus Torvalds
2012-02-19 19:49 ` David Miller
2012-02-19 20:02 ` Linus Torvalds
2012-02-20 3:28 ` Ian Kent
2012-02-21 3:29 ` Ian Kent
2012-02-21 3:38 ` Linus Torvalds
2012-02-21 4:02 ` Ian Kent
2012-02-21 4:17 ` Linus Torvalds
2012-02-21 4:52 ` Ian Kent
2012-02-21 5:06 ` Linus Torvalds
2012-02-21 5:21 ` Linus Torvalds
2012-02-21 5:27 ` H. Peter Anvin
2012-02-21 5:28 ` H. Peter Anvin
2012-02-21 5:32 ` Linus Torvalds
2012-02-21 5:39 ` Ian Kent
2012-02-21 4:18 ` H. Peter Anvin
2012-02-21 4:22 ` H. Peter Anvin
2012-02-21 13:03 ` Alan Cox
2012-02-21 18:26 ` Use gcc to check exported files [Was: Linux 3.3-rc4] Sam Ravnborg
2012-02-21 18:58 ` Thomas Meyer [this message]
2012-02-21 22:07 ` Linux 3.3-rc4 Linus Torvalds
2012-02-21 22:43 ` Linus Torvalds
2012-02-21 23:10 ` Eric Dumazet
2012-02-21 23:19 ` Linus Torvalds
2012-02-24 10:39 ` Jiri Kosina
2012-02-24 16:52 ` Linus Torvalds
2012-02-24 18:01 ` Jiri Kosina
2012-02-24 18:21 ` Linus Torvalds
2012-02-29 8:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329850714.1419.2.camel@localhost.localdomain \
--to=thomas@m3y3r.de \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox