From: "Alex,Shi" <alex.shi@intel.com>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
linux-usb@vger.kernel.org, andiry.xu@amd.com, clemens@ladisch.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] usb: enable pci MSI/MSIX in usb core
Date: Thu, 23 Feb 2012 17:11:47 +0800 [thread overview]
Message-ID: <1329988307.21053.167.camel@debian> (raw)
In-Reply-To: <1329986384.21053.165.camel@debian>
> What do you mean: there is a relation between event rings
> msix_entries.vectors. and we need to presents this relationships in the
> msix interrupt handler?
>
> So does the following mode you like?
>
> request_irq(hcd->msix_entries[i].vector, msix_irq_handler, 0, "",
> hcd->ring_handler[i]);
>
> Or another way to do it if we know which ring will handle the irq, like:
here, I mean let the driver remember this relationships.
>
> irqreturn_t xhci_msi_irq(int irq, struct usb_hcd *hcd)
>
> switch (irq2ring(irq))
> case ring0: driver_handle_ring(ring0);
> case ring1: driver_handle_ring(ring1);
>
> In fact, since there is no actual usage of multiple rings now, I have no
> much idea of the relationships.
>
> BTW, if it is possible do this change to another patch?
next prev parent reply other threads:[~2012-02-23 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 9:05 [PATCH v2 0/3] enable pci MSI/MSIX in usb core Alex Shi
2012-02-20 9:05 ` [PATCH 1/3] USB: Try MSI first before line IRQ for Intel PCIe USB3 HCD Alex Shi
2012-02-20 9:05 ` [PATCH 2/3] usb: enable pci MSI/MSIX in usb core Alex Shi
2012-02-20 9:05 ` [PATCH 3/3] usb: export usb_hcd_request_irqs Alex Shi
2012-02-23 3:41 ` [PATCH 2/3] usb: enable pci MSI/MSIX in usb core Sarah Sharp
2012-02-23 8:39 ` Alex,Shi
2012-02-23 9:11 ` Alex,Shi [this message]
2012-02-23 12:41 ` Felipe Balbi
2012-02-24 1:47 ` Alex,Shi
2012-02-24 10:00 ` Felipe Balbi
2012-02-24 15:59 ` Alan Stern
2012-02-28 1:43 ` Alex,Shi
2012-02-26 10:16 ` Alex Shi
2012-03-06 17:55 ` [PATCH 1/3] USB: Try MSI first before line IRQ for Intel PCIe USB3 HCD Tom Goetz
[not found] <1329728040-28664-1-git-send-email-alex.shi@intel.com>
2012-02-20 8:53 ` [PATCH 2/3] usb: enable pci MSI/MSIX in usb core Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329988307.21053.167.camel@debian \
--to=alex.shi@intel.com \
--cc=andiry.xu@amd.com \
--cc=balbi@ti.com \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).