* [PATCH v3] regulator: Set delay to 0 if set_voltage_time_sel callback returns error
@ 2012-02-24 15:13 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2012-02-24 15:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Liam Girdwood, Mark Brown
rdev->desc->ops->set_voltage_time_sel may return negative error code.
Set delay to 0 and also show warning if set_voltage_time_sel returns error.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
v3: only coding style change, the result should be the same as v2.
v2: show warning message if set_voltage_time_sel returns error.
drivers/regulator/core.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index beeeb7f..5a6b8ba 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1890,8 +1890,12 @@ static int _regulator_do_set_voltage(struct regulator_dev *rdev,
if (ret < 0)
return ret;
old_selector = ret;
- delay = rdev->desc->ops->set_voltage_time_sel(rdev,
+ ret = rdev->desc->ops->set_voltage_time_sel(rdev,
old_selector, selector);
+ if (ret < 0)
+ rdev_warn(rdev, "set_voltage_time_sel() failed: %d\n", ret);
+ else
+ delay = ret;
}
if (best_val != INT_MAX) {
--
1.7.5.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-02-24 15:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-24 15:13 [PATCH v3] regulator: Set delay to 0 if set_voltage_time_sel callback returns error Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox