public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <srostedt@redhat.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH, v2] x86-64: fix CFI annotations for NMI nesting code
Date: Fri, 24 Feb 2012 11:47:03 -0500	[thread overview]
Message-ID: <1330102023.3306.22.camel@fedora> (raw)
In-Reply-To: <4F47B2BD0200007800074AD7@nat28.tlf.novell.com>

On Fri, 2012-02-24 at 14:54 +0000, Jan Beulich wrote:
> The saving and restoring of %rdx wasn't annotated at all, and the
> jumping over sections where state gets partly restored wasn't handled
> either.
> 
> Further, by folding the pushing of the previous frame in repeat_nmi
> into that which so far was immediately preceding restart_nmi (after
> moving the restore of %rdx ahead of that, since it doesn't get used
> anymore when pushing prior frames), annotations of the replicated
> frame creations can be made consistent too.
> 
> v2: Fully fold repeat_nmi into the normal code flow (adding a single
>     redundant instruction to the "normal" code path), thus retaining
>     the special protection of all instructions between repeat_nmi and
>     end_repeat_nmi.

Thanks, I'll start testing it.

> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Cc: Steven Rostedt <srostedt@redhat.com>

FYI, please send to my rostedt@goodmis.org account. My RH account is a
second class citizen that I use to read RH status updates and such. I
don't conduct upstream work from it and I may ignore it for long periods
of time.

I author code with it just to give credit to the company that pays me,
but my SOB is always the goodmis.org account.

Thanks,

-- Steve



      reply	other threads:[~2012-02-24 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24 14:54 [PATCH, v2] x86-64: fix CFI annotations for NMI nesting code Jan Beulich
2012-02-24 16:47 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330102023.3306.22.camel@fedora \
    --to=srostedt@redhat.com \
    --cc=JBeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox