From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757921Ab2BXQ6Q (ORCPT ); Fri, 24 Feb 2012 11:58:16 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:55978 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984Ab2BXQ6O (ORCPT ); Fri, 24 Feb 2012 11:58:14 -0500 From: santosh nayak To: benve@cisco.com Cc: roprabhu@cisco.com, neepatel@cisco.com, nistrive@cisco.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH 2/2] enic: Silence Sparse Warning: "dubious: x | !y" Date: Fri, 24 Feb 2012 22:27:34 +0530 Message-Id: <1330102654-2474-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Santosh Nayak Sparse is giving the following warning: "warning: dubious: x | !y" "enic_are_pp_different" is static and expected to return true or false. Logical or is indended here. With logical or, in best case, execution will be faster because if leftmost operand is true then no need to check other operands. Signed-off-by: Santosh Nayak --- drivers/net/ethernet/cisco/enic/enic_pp.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c index dafea1e..3a6de22 100644 --- a/drivers/net/ethernet/cisco/enic/enic_pp.c +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c @@ -159,10 +159,10 @@ static int enic_unset_port_profile(struct enic *enic, int vf) static int enic_are_pp_different(struct enic_port_profile *pp1, struct enic_port_profile *pp2) { - return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid, - pp2->instance_uuid, PORT_UUID_MAX) | - !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) | - !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); + return strcmp(pp1->name, pp2->name) || !!memcmp(pp1->instance_uuid, + pp2->instance_uuid, PORT_UUID_MAX) || + !!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) || + !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN); } static int enic_pp_preassociate(struct enic *enic, int vf, -- 1.7.4.4