From: Yinghai Lu <yinghai@kernel.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: [PATCH 04/11] PCI: rename pci_host_bridge() to find_pci_root_bridge()
Date: Mon, 27 Feb 2012 18:03:44 -0800 [thread overview]
Message-ID: <1330394631-28978-5-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1330394631-28978-1-git-send-email-yinghai@kernel.org>
Separate find_pci_root_bus out.
-v2: according to Bjorn, remove extra null checking.
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
drivers/pci/host-bridge.c | 18 +++++++++++++-----
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c
index dfaff3f..b3ddcc5 100644
--- a/drivers/pci/host-bridge.c
+++ b/drivers/pci/host-bridge.c
@@ -16,15 +16,22 @@ void add_to_pci_host_bridges(struct pci_host_bridge *bridge)
list_add_tail(&bridge->list, &pci_host_bridges);
}
-static struct pci_host_bridge *pci_host_bridge(struct pci_dev *dev)
+static struct pci_bus *find_pci_root_bus(struct pci_dev *dev)
{
struct pci_bus *bus;
- struct pci_host_bridge *bridge;
bus = dev->bus;
while (bus->parent)
bus = bus->parent;
+ return bus;
+}
+
+static struct pci_host_bridge *find_pci_host_bridge(struct pci_dev *dev)
+{
+ struct pci_bus *bus = find_pci_root_bus(dev);
+ struct pci_host_bridge *bridge;
+
list_for_each_entry(bridge, &pci_host_bridges, list) {
if (bridge->bus == bus)
return bridge;
@@ -42,7 +49,7 @@ void __weak pcibios_resource_to_bus(struct pci_dev *dev,
struct pci_bus_region *region,
struct resource *res)
{
- struct pci_host_bridge *bridge = pci_host_bridge(dev);
+ struct pci_host_bridge *bridge = find_pci_host_bridge(dev);
struct pci_host_bridge_window *window;
resource_size_t offset = 0;
@@ -70,12 +77,13 @@ static bool region_contains(struct pci_bus_region *region1,
void __weak pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
struct pci_bus_region *region)
{
- struct pci_host_bridge *bridge = pci_host_bridge(dev);
+ struct pci_host_bridge *bridge = find_pci_host_bridge(dev);
struct pci_host_bridge_window *window;
- struct pci_bus_region bus_region;
resource_size_t offset = 0;
list_for_each_entry(window, &bridge->windows, list) {
+ struct pci_bus_region bus_region;
+
if (resource_type(res) != resource_type(window->res))
continue;
--
1.7.7
next prev parent reply other threads:[~2012-02-28 2:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 2:03 [PATCH -v2 00/11] PCI: pci_host_bridge related cleanup Yinghai Lu
2012-02-28 2:03 ` [PATCH 01/11] PCI: Separate host_bridge code out from probe.c Yinghai Lu
2012-02-28 2:03 ` [PATCH 02/11] x86, PCI: have own version for pcibios_bus_to_resource Yinghai Lu
2012-02-28 2:03 ` [PATCH 03/11] x86, PCI: Fix memleak with get_current_resources Yinghai Lu
2012-02-28 2:03 ` Yinghai Lu [this message]
2012-02-28 2:03 ` [PATCH 05/11] PCI: add generic device into pci_host_bridge struct Yinghai Lu
2012-02-28 2:03 ` [PATCH 06/11] PCI: add host bridge release support Yinghai Lu
2012-02-28 2:03 ` [PATCH 07/11] x86, PCI: break down get_current_resource() Yinghai Lu
2012-02-28 2:03 ` [PATCH 08/11] x86, PCI: add host bridge resource release for using _CRS Yinghai Lu
2012-02-28 2:03 ` [PATCH 09/11] x86, PCI: embed name acpi version pci_root_info struct Yinghai Lu
2012-02-28 2:03 ` [PATCH 10/11] x86, PCI: Allocating pci_root_info for nocrs path Yinghai Lu
2012-02-28 2:03 ` [PATCH 11/11] x86, PCI: Merge root info printing " Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330394631-28978-5-git-send-email-yinghai@kernel.org \
--to=yinghai@kernel.org \
--cc=bhelgaas@google.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).