From: John Stultz <john.stultz@linaro.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: lkml <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <eric.dumazet@gmail.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH 1/7] time: Condense timekeeper.xtime into xtime_sec
Date: Tue, 28 Feb 2012 00:17:20 -0800 [thread overview]
Message-ID: <1330417040.2340.344.camel@work-vm> (raw)
In-Reply-To: <20120228080647.GC21106@elte.hu>
On Tue, 2012-02-28 at 09:06 +0100, Ingo Molnar wrote:
> * John Stultz <john.stultz@linaro.org> wrote:
> > +
> > +static void timekeeper_set_xtime(struct timekeeper *tk,
> > + const struct timespec *ts)
>
> Pointless (because ugly) line break.
>
> > +{
> > + tk->xtime_sec = ts->tv_sec;
> > + tk->xtime_nsec = ts->tv_nsec << tk->shift;
> > +}
> > +
> > +
> > +static void timekeeper_xtime_add(struct timekeeper *tk,
> > + const struct timespec *ts)
>
> Pointless (because ugly) line break.
Ack on your other comments, but I'm not sure I'm following you here.
What would you rather see in this case?
(I know the 80col limit was discussed recently, but it didn't sound like
the consensus was for extending it.)
thanks
-john
next prev parent reply other threads:[~2012-02-28 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 0:29 [GIT PULL][PATCH 0/7] Reduce timekeeping lock hold time John Stultz
2012-02-28 0:29 ` [PATCH 1/7] time: Condense timekeeper.xtime into xtime_sec John Stultz
2012-02-28 8:06 ` Ingo Molnar
2012-02-28 8:17 ` John Stultz [this message]
2012-02-28 8:30 ` Ingo Molnar
2012-02-28 0:29 ` [PATCH 2/7] time: Rework timekeeping functions to take timekeeper ptr as argument John Stultz
2012-02-28 0:29 ` [PATCH 3/7] time: Split timekeeper lock into separate reader/writer locks John Stultz
2012-02-28 8:08 ` Ingo Molnar
2012-02-28 0:29 ` [PATCH 4/7] time: Update timekeeper structure using a local shadow John Stultz
2012-02-28 8:12 ` Ingo Molnar
2012-02-28 0:29 ` [PATCH 5/7] time: Shadow cycle_last in timekeeper structure John Stultz
2012-02-28 8:16 ` Ingo Molnar
2012-02-28 0:29 ` [PATCH 6/7] time: Reduce timekeeper read lock hold time John Stultz
2012-02-28 0:29 ` [PATCH 7/7] time: Convert the timekeeper's wlock to a raw_spin_lock John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330417040.2340.344.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).