From: Jonas Bonn <jonas@southpole.se>
To: Richard Weinberger <richard@nod.at>
Cc: arnd@arndb.de, linux@openrisc.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage
Date: Wed, 29 Feb 2012 08:46:32 +0100 [thread overview]
Message-ID: <1330501592.2964.1.camel@crucifix> (raw)
In-Reply-To: <1330476393-14264-1-git-send-email-richard@nod.at>
Thanks, Richard. There is, however, already a patch in linux-next that
provides this fix.
/Jonas
On Wed, 2012-02-29 at 01:46 +0100, Richard Weinberger wrote:
> Commit d7e7528 (Audit: push audit success and retcode into arch ptrace.h)
> changed audit_syscall_exit().
>
> Fixes:
> CC arch/openrisc/kernel/ptrace.o
> arch/openrisc/kernel/ptrace.c: In function ‘do_syscall_trace_leave’:
> arch/openrisc/kernel/ptrace.c:206:21: error: macro "audit_syscall_exit" passed 2 arguments, but takes just 1
> arch/openrisc/kernel/ptrace.c:205:3: error: ‘audit_syscall_exit’ undeclared (first use in this function)
> arch/openrisc/kernel/ptrace.c:205:3: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/openrisc/kernel/ptrace.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/kernel/ptrace.c b/arch/openrisc/kernel/ptrace.c
> index 656b94b..fa381b2 100644
> --- a/arch/openrisc/kernel/ptrace.c
> +++ b/arch/openrisc/kernel/ptrace.c
> @@ -202,8 +202,7 @@ asmlinkage void do_syscall_trace_leave(struct pt_regs *regs)
> int step;
>
> if (unlikely(current->audit_context))
> - audit_syscall_exit(AUDITSC_RESULT(regs->gpr[11]),
> - regs->gpr[11]);
> + audit_syscall_exit(regs);
>
> step = test_thread_flag(TIF_SINGLESTEP);
> if (step || test_thread_flag(TIF_SYSCALL_TRACE))
next prev parent reply other threads:[~2012-02-29 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 0:46 [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage Richard Weinberger
2012-02-29 0:46 ` [PATCH 2/2] OpenRISC: IRQ: Include module.h Richard Weinberger
2012-02-29 7:49 ` Jonas Bonn
2012-02-29 8:39 ` Richard Weinberger
2012-02-29 8:56 ` Jonas Bonn
2012-02-29 7:46 ` Jonas Bonn [this message]
2012-02-29 8:34 ` [PATCH 1/2] OpenRISC: Fix audit_syscall_exit() usage Richard Weinberger
2012-02-29 8:48 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330501592.2964.1.camel@crucifix \
--to=jonas@southpole.se \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@openrisc.net \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox