RE: coding style issues -- [davem@davemloft.net: Re: pull request: wireless-next 2012-02-06]

Bing Zhao
2012-02-29T19:25:18Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1399 bytes --]

Hi Joe,

> Subject: RE: coding style issues -- [davem@davemloft.net: Re: pull request: wireless-next 2012-02-06]
>
> On Wed, 2012-02-29 at 10:57 -0800, Bing Zhao wrote:
> > Joe Perches submitted a patch "[PATCH v2] checkpatch: Add some --strict coding style checks"
> > I have applied Joe's patch to my local git tree.
> >
> > All new patches will follow Dave's rules and be checked with --strict option.
> > Furthermore, we will have a series of cleanup patches to address the coding style issues in
> existing code.
>
> Hi Bing.
>
> There's an issue with the checkpatch patch.
> It doesn't always work correctly when there
> are consecutive parenthesis.
>
> Kalle Valo showed an example that fails:
>
> if (!IS_ALIGNED((unsigned long) skb->data - HTC_HDR_LENGTH, 4) &&
> skb_cloned(skb)) {

Thanks for letting us know.

>
> I have a tentative fix here, but I'm waiting on
> Andy Whitcroft to give some guidance on how best
> to fix it given a minimum perl version of 5.10.

I have "Perl v5.10.0 built for x86_64-linux-gnu-thread-multi" on my system.
I guess it should be fine.

Thanks,
Bing

>
> The proposed patch doesn't work with perl versions
> less than 5.10 and there is at least one person
> that still uses 5.8.
>

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥