Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

Richard Weinberger
2012-03-02T08:47:12Z

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Am 02.03.2012 07:50, schrieb Jonas Bonn:
> On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
>> There is no need to reinvent the wheel.
>
> NAK... we have optimized versions for some of these operations so the
> generic header isn't right for us.

Sorry, I missed that.

> Have a look at arch/openrisc/asm/include/bitops.h to see which functions
> we override with accelerated versions.

Okay, but some operations are missing in your bitopts.h.
Like test_bit_le() or find_next_zero_bit_le().

#include <asm-generic/bitops/le.h>
Should to the job...

Thanks,
//richard

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]