Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

Jonas Bonn
2012-03-02T06:50:56Z

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
> There is no need to reinvent the wheel.

NAK... we have optimized versions for some of these operations so the
generic header isn't right for us.

Have a look at arch/openrisc/asm/include/bitops.h to see which functions
we override with accelerated versions.

/Jonas

>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/openrisc/include/asm/Kbuild | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/Kbuild b/arch/openrisc/include/asm/Kbuild
> index 11162e6..a283165 100644
> --- a/arch/openrisc/include/asm/Kbuild
> +++ b/arch/openrisc/include/asm/Kbuild
> @@ -4,6 +4,7 @@ header-y += spr_defs.h
>
> generic-y += atomic.h
> generic-y += auxvec.h
> +generic-y += bitops.h
> generic-y += bitsperlong.h
> generic-y += bug.h
> generic-y += bugs.h

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]