From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758149Ab2CBHCw (ORCPT ); Fri, 2 Mar 2012 02:02:52 -0500 Received: from mga11.intel.com ([192.55.52.93]:25722 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756768Ab2CBHCs (ORCPT ); Fri, 2 Mar 2012 02:02:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="124049427" Subject: Re: [RFC PATCH v2 8/8] [SCSI] sr: check and enable Zero-power ODD support From: Lin Ming To: Alan Stern Cc: Zhang Rui , Jeff Garzik , "Rafael J. Wysocki" , Tejun Heo , Aaron Lu , Kernel development list , linux-ide@vger.kernel.org, SCSI development list , Linux-pm mailing list , linux-acpi In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Date: Fri, 02 Mar 2012 15:02:45 +0800 Message-ID: <1330671765.3412.7.camel@minggr> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-03-01 at 11:02 -0500, Alan Stern wrote: > On Thu, 1 Mar 2012, Lin Ming wrote: > > > ZPODD(Zero Power Optical Disk Drive) is a new feature in > > SATA 3.1 specification. It provides a way to power off unused ODD. > > > > ZPODD support is checked in in sr_probe(). > > can_power_off flag is set during suspend if ZPODD is supported. > > > > ATA port's runtime suspend callback will actually power off the ODD > > and its runtime resume callback will actually power on the ODD. > > > > When ODD is powered off(D3Cold state), inserting disk will trigger a > > wakeup event(GPE). GPE AML handler notifies the associated device. Then > > ODD is resumed in the notify handler. > > I have one stylistic comment on this patch... > > > diff --git a/drivers/scsi/sr.h b/drivers/scsi/sr.h > > index 37c8f6b..39b3d8c 100644 > > --- a/drivers/scsi/sr.h > > +++ b/drivers/scsi/sr.h > > @@ -42,6 +42,9 @@ typedef struct scsi_cd { > > unsigned readcd_cdda:1; /* reading audio data using READ_CD */ > > unsigned media_present:1; /* media is present */ > > > > + unsigned zpodd:1; /* is ZPODD supported */ > > + unsigned zpodd_event:1; > > + > > You should not expect your readers to understand what "ZPODD" means. > drivers/scsi/sr.h is used by lots of different people, many of whom > will have no idea what it refers to, especially since it is part of > the SATA spec and not the SCSI spec. You should provide a brief > explanation. I'll add some explanation. But I'm thinking maybe it's better to move this flag to ata layer, for example, adding a flag to libata.h ATA_DFLAG_ZPODD sr runtime pm is only enabled when ZPODD(or more general, power off) is supported. So the problem is how will sr driver know this flag? > > Alan Stern >