Re: [PATCH 06/23] PCI: rescan with bus or bridge using callback method too

Yinghai Lu
2012-03-09T19:05:38Z

On Fri, Mar 9, 2012 at 9:22 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> Why did you just repeat my proposal, changing "err" to "ret"?  I
> missed the point you're trying to make.  The name "err" gives an
> important clue that device_schedule_callback() returns 0 or errno.
> That's essential to understanding the code.
>
> Your original patch has one "return."  Mine proposal has three.  All
> that means is that the reader of your patch has to manage more stuff
> in her head to understand the code.  That's not a benefit!

ok, can we have separated patch to fix them all?

Yinghai