public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: "randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
	"linaro-dev@lists.linaro.org" <linaro-dev@lists.linaro.org>,
	"dchen@diasemi.com" <dchen@diasemi.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"sameo@linux.intel.com" <sameo@linux.intel.com>
Subject: Re: [PATCH 02/03] HWMON: HWMON driver for DA9052/53 PMIC v3
Date: Wed, 7 Mar 2012 11:08:22 -0800	[thread overview]
Message-ID: <1331147302.23014.370.camel@groeck-laptop> (raw)
In-Reply-To: <1330698545.21817.31.camel@dhruva>

On Fri, 2012-03-02 at 09:29 -0500, Ashish Jangam wrote:
> The DA9052 PMIC provides an Analogue to Digital Converter with 10 bits
> resolution and 10 channels.
> 
> This patch monitors the DA9052 PMIC's ADC channels mostly for battery
> parameters like battery temperature, junction temperature, battery
> current etc.
> 
> This patch is functionally tested on Samsung SMDKV6410
> 
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>

Only comment I would have is that it might make sense to use
DIV_ROUND_CLOSEST(). That is a minor issue, though, so feel free to add

Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>

Question is where this is going. I can not add it to hwmon-next without
the matching mfd changes. Any idea ?

Thanks,
Guenter



  parent reply	other threads:[~2012-03-07 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 14:29 [PATCH 02/03] HWMON: HWMON driver for DA9052/53 PMIC v3 Ashish Jangam
2012-03-02 16:44 ` [lm-sensors] " R, Durgadoss
2012-03-02 16:50   ` Guenter Roeck
2012-03-02 16:54     ` R, Durgadoss
2012-03-07 19:08 ` Guenter Roeck [this message]
2012-03-08  2:21   ` Ashish Jangam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331147302.23014.370.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=ashish.jangam@kpitcummins.com \
    --cc=dchen@diasemi.com \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox