From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758531Ab2CGWZB (ORCPT ); Wed, 7 Mar 2012 17:25:01 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:55164 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728Ab2CGWY5 (ORCPT ); Wed, 7 Mar 2012 17:24:57 -0500 Message-ID: <1331159086.2191.190.camel@work-vm> Subject: Re: [PATCH 01/13] android: lowmemorykiller: Fix warning on 64bit From: John Stultz To: Greg KH Cc: lkml , Android Kernel Team Date: Wed, 07 Mar 2012 14:24:46 -0800 In-Reply-To: <20120307220454.GA16555@kroah.com> References: <1331157503-3413-1-git-send-email-john.stultz@linaro.org> <1331157503-3413-2-git-send-email-john.stultz@linaro.org> <20120307220454.GA16555@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 8bit Mime-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12030722-3352-0000-0000-0000032C99CD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-03-07 at 14:04 -0800, Greg KH wrote: > On Wed, Mar 07, 2012 at 01:58:11PM -0800, John Stultz wrote: > > Fixes the following warning on 64bit: > > drivers/staging/android/lowmemorykiller.c: In function ‘__check_minfree’: > > drivers/staging/android/lowmemorykiller.c:215: warning: return from incompatible pointer type > > > > CC: Greg KH > > CC: Android Kernel Team > > Signed-off-by: John Stultz > > --- > > drivers/staging/android/lowmemorykiller.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > > index 052b43e..15a59c1 100644 > > --- a/drivers/staging/android/lowmemorykiller.c > > +++ b/drivers/staging/android/lowmemorykiller.c > > @@ -212,7 +212,7 @@ static void __exit lowmem_exit(void) > > module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > > module_param_array_named(adj, lowmem_adj, int, &lowmem_adj_size, > > S_IRUGO | S_IWUSR); > > -module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, > > +module_param_array_named(minfree, lowmem_minfree, ulong, &lowmem_minfree_size, > > S_IRUGO | S_IWUSR); > > No, the correct fix for this is to make lowmem_minfree an int, not > size_t, right? I made that fix an hour ago in my tree. Looks ok to me. I'll go ahead and drop this then. thanks -john