Re: [PATCH 05/11] android: ram_console: split out persistent ram

Greg KH
2012-03-08T02:42:12Z

On Wed, Mar 07, 2012 at 05:34:32PM -0800, John Stultz wrote:
> From: Colin Cross <ccross@android.com>
>
> Split ram_console into two halves.
>
> persistent_ram is a set of apis that handle a block of memory
> that does not get erased across a reboot. It provides functions
> to fill it as a single buffer or a ring buffer, and to extract
> the old data after a reboot. It handles ecc on the data to
> correct bit errors introduced during reboot.

That's a nice idea, but why are you rolling your own interface here and
not using the built-in one that the kernel already provides? Is there
something lacking with what we have today that requires you to create
something different? If so, why not just modify the existing interface
to make it work for you, that way the tools already created will work
automatically, and you will not have problems later ripping this out and
porting it to the in-kernel api.

Because of this, sorry, I can't take the rest of these patches in this
series. If the 10th or 11th ones are needed, care to refresh it against
my tree and resend it so that I can take it?

thanks,

greg k-h