From: Matt Fleming <matt.fleming@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
mingo@redhat.com, mjg@redhat.com, linux-kernel@vger.kernel.org,
keithp@keithp.com, rui.zhang@intel.com,
huang.ying.caritas@gmail.com, stable@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86, efi: Delete efi_ioremap() and fix CONFIG_X86_32 oops
Date: Thu, 08 Mar 2012 12:09:38 +0000 [thread overview]
Message-ID: <1331208578.3539.79.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CAE9FiQWrh5fOzAj_f03iqF+pQjGExvzppVoeJjwnp0p030jDPA@mail.gmail.com>
On Wed, 2012-03-07 at 10:14 -0800, Yinghai Lu wrote:
> > +
> > + if (end <= max_low_pfn << PAGE_SHIFT)
> > + max_low_pfn_mapped = last_pfn_mapped;
>
> those two line could be dropped if you have
> last_pfn_mapped = 1<<(20 - 12);
> before the loop
When you say "dropped" do you mean "not executed" or "deleted because
they are unnecessary"?
> Also you can not use max_low_pfn here...
Why not? Please explain.
> you need to update e820_end_pfn to search max pfn for several types like
> > + case E820_RAM:
> > + case E820_RESERVED_EFI:
> > + case E820_ACPI:
> > + case E820_NVS:
Yeah, that's a good point. I'll make that change.
> but my question is:
> is there any system that will put EFI runtime, or ACPI or NVS above
> 4G? is that legal?
Matthew already answered this. I think it's entirely possible that EFI
runtime regions can reside above 4G.
next prev parent reply other threads:[~2012-03-09 10:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 13:30 [PATCH] x86, efi: Delete efi_ioremap() and fix CONFIG_X86_32 oops Matt Fleming
2012-02-23 1:16 ` [tip:x86/urgent] " tip-bot for Matt Fleming
2012-02-23 2:20 ` Yinghai Lu
2012-02-23 3:32 ` H. Peter Anvin
2012-02-23 10:36 ` Yinghai Lu
2012-02-24 4:47 ` H. Peter Anvin
2012-02-28 2:27 ` H. Peter Anvin
2012-03-07 10:30 ` Matt Fleming
2012-03-07 18:05 ` Yinghai Lu
2012-03-08 11:28 ` Matt Fleming
2012-03-08 18:59 ` Yinghai Lu
2012-03-12 12:38 ` Matt Fleming
2012-03-13 5:39 ` Yinghai Lu
2012-03-15 12:40 ` Matt Fleming
2012-03-15 17:54 ` Yinghai Lu
2012-03-16 18:36 ` Matt Fleming
2012-03-16 19:01 ` Yinghai Lu
2012-03-07 18:14 ` Yinghai Lu
2012-03-07 18:18 ` Matthew Garrett
2012-03-08 12:09 ` Matt Fleming [this message]
2012-03-04 0:12 ` Keith Packard
2012-03-04 0:27 ` H. Peter Anvin
2012-03-04 1:33 ` Keith Packard
2012-03-05 10:45 ` Ingo Molnar
2012-03-07 18:31 ` Yinghai Lu
2012-03-05 11:48 ` Matt Fleming
2012-02-28 2:33 ` [PATCH] " H. Peter Anvin
2012-02-28 17:35 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331208578.3539.79.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt.fleming@intel.com \
--cc=hpa@kernel.org \
--cc=huang.ying.caritas@gmail.com \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg@redhat.com \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).