public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2 V2] checkpatch: Warn on use of yield()
Date: Thu, 08 Mar 2012 07:56:01 -0800	[thread overview]
Message-ID: <1331222161.30848.1.camel@joe2Laptop> (raw)
In-Reply-To: <1331057839.2140.12.camel@joe2Laptop>

Using yield() is generally wrong.  Warn on its use.

Signed-off-by: Joe Perches <joe@perches.com>
---

V2: Test checkpatches first next time...
    Add missing close parenthesis

 scripts/checkpatch.pl |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 04eb9eb..135cb8f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3344,6 +3344,12 @@ sub process {
 			     "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
 		}
 
+# check for use of yield()
+		if ($line =~ /\byield\s*\(\s*\)/) {
+			WARN("YIELD",
+			     "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n"  . $herecurr);
+		}
+
 # check for semaphores initialized locked
 		if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
 			WARN("CONSIDER_COMPLETION",



  parent reply	other threads:[~2012-03-08 15:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 11:23 [PATCH] cpuset: mm: Remove memory barrier damage from the page allocator Mel Gorman
2012-03-02 16:19 ` Christoph Lameter
2012-03-02 17:43   ` Mel Gorman
2012-03-02 19:53     ` Christoph Lameter
2012-03-02 21:25     ` Peter Zijlstra
2012-03-02 23:47       ` David Rientjes
2012-03-05  9:44         ` Mel Gorman
2012-03-06 23:31           ` David Rientjes
2012-03-05  9:35       ` Mel Gorman
2012-03-02 21:21 ` Peter Zijlstra
2012-03-05 20:18   ` Andrew Morton
2012-03-06  2:01     ` [RFC PATCH] checkpatch: Warn on use of yield() Joe Perches
2012-03-06 12:45       ` Peter Zijlstra
2012-03-06 13:14         ` Glauber Costa
2012-03-06 13:25           ` Peter Zijlstra
2012-03-06 13:27             ` Glauber Costa
2012-03-06 17:41         ` Joe Perches
2012-03-06 17:54           ` Peter Zijlstra
2012-03-06 18:00             ` Joe Perches
2012-03-06 18:17               ` Joe Perches
2012-03-06 19:31                 ` [PATCH 1/2] " Joe Perches
2012-03-06 19:31                   ` [PATCH 2/2] checkpatch: whitespace - add/remove blank lines Joe Perches
2012-03-08 15:56                 ` Joe Perches [this message]
2012-03-13  4:47             ` [tip:sched/core] sched: Update yield() docs tip-bot for Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331222161.30848.1.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox