From: Fabio Estevam <festevam@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: vinod.koul@intel.com, kernel@pengutronix.de,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH] dma: imx-dma: Fix build by including <linux/module.h>
Date: Thu, 8 Mar 2012 18:26:45 -0300 [thread overview]
Message-ID: <1331242005-15533-1-git-send-email-festevam@gmail.com> (raw)
commit 13ae246 (includecheck: delete any duplicate instances of module.) removed
a duplicated module.h inclusion from imx-dma.c.
,and commit 865d9438 (drivers/dma: linux/module.h included twice) did the same.
Let one linux/module.h be included so that it can be built again.
This fix the following error:
C drivers/dma/imx-dma.o
drivers/dma/imx-dma.c:658: error: expected declaration specifiers or '...' before string constant
drivers/dma/imx-dma.c:658: warning: data definition has no type or storage class
drivers/dma/imx-dma.c:658: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
drivers/dma/imx-dma.c:658: warning: function declaration isn't a prototype
drivers/dma/imx-dma.c:659: error: expected declaration specifiers or '...' before string constant
drivers/dma/imx-dma.c:659: warning: data definition has no type or storage class
drivers/dma/imx-dma.c:659: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
drivers/dma/imx-dma.c:659: warning: function declaration isn't a prototype
drivers/dma/imx-dma.c:660: error: expected declaration specifiers or '...' before string constant
drivers/dma/imx-dma.c:660: warning: data definition has no type or storage class
drivers/dma/imx-dma.c:660: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
drivers/dma/imx-dma.c:660: warning: function declaration isn't a prototype
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/imx-dma.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
index ca78fca..7be8d1f 100644
--- a/drivers/dma/imx-dma.c
+++ b/drivers/dma/imx-dma.c
@@ -25,6 +25,7 @@
#include <linux/slab.h>
#include <linux/platform_device.h>
#include <linux/dmaengine.h>
+#include <linux/module.h>
#include <asm/irq.h>
#include <mach/dma-v1.h>
--
1.7.1
next reply other threads:[~2012-03-08 21:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 21:26 Fabio Estevam [this message]
2012-03-13 4:23 ` [PATCH] dma: imx-dma: Fix build by including <linux/module.h> Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331242005-15533-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox