From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [ANNOUNCE] 3.2.9-rt17
Date: Thu, 08 Mar 2012 23:20:13 +0100 [thread overview]
Message-ID: <1331245213.11248.446.camel@twins> (raw)
In-Reply-To: <1331244812.25686.518.camel@gandalf.stny.rr.com>
On Thu, 2012-03-08 at 17:13 -0500, Steven Rostedt wrote:
> > task-A (cpu0) task-B (cpu1) task-C (cpu1)
> >
> > lock ->d_lock
> > lock ->i_lock
> > lock ->d_lock
> > <-------------- preempts B
> > trylock ->i_lock
> >
> >
> > While is is perfectly normal, the result is that A stops spinning and
> > goes to sleep. Now B continues and loops ad infinitum because it keeps
> > getting ->d_lock before A because its cache hot on cpu1 and waking A
> > takes a while etc..
>
> I'm confused? As A isn't doing a loop. B is doing the loop because it's
> trying to grab the locks in reverse order and can't take the i_lock.
> Your example above would have A go to sleep when it tries to take
> d_lock.
Right, but what guarantees that A will ever get ->d_lock when B releases
it before B again acquires it?
B is in a very tight:
1:
lock ->d_lock
trylock ->i_lock
unlock ->d_lock
goto 1
loop, while A is doing:
1:
trylock ->d_lock
goto 1
and with rt-mutex having the equal priority lock stealing this reverts
to a plain test-and-set lock. There's only a tiny window in which A can
actually get the lock and that is hampered by B's cpu owning the
cacheline in exclusive mode.
I simply cannot see guaranteed progress here.
next prev parent reply other threads:[~2012-03-08 22:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 21:49 [ANNOUNCE] 3.2.9-rt17 Thomas Gleixner
2012-03-08 18:23 ` Steven Rostedt
2012-03-08 18:28 ` Peter Zijlstra
2012-03-08 18:42 ` Steven Rostedt
2012-03-08 19:39 ` Peter Zijlstra
2012-03-08 20:10 ` Steven Rostedt
2012-03-08 20:26 ` Peter Zijlstra
2012-03-08 21:08 ` Steven Rostedt
2012-03-08 21:20 ` Peter Zijlstra
2012-03-08 21:25 ` Steven Rostedt
2012-03-08 21:28 ` Peter Zijlstra
2012-03-08 21:36 ` Steven Rostedt
2012-03-08 21:37 ` Peter Zijlstra
2012-03-08 21:44 ` Steven Rostedt
2012-03-08 21:54 ` Peter Zijlstra
2012-03-08 22:13 ` Steven Rostedt
2012-03-08 22:20 ` Peter Zijlstra [this message]
2012-03-08 22:27 ` Steven Rostedt
2012-03-09 4:17 ` Steven Rostedt
2012-03-09 0:33 ` Thomas Gleixner
2012-03-09 3:08 ` Steven Rostedt
2012-03-09 0:20 ` Thomas Gleixner
2012-03-09 2:50 ` Steven Rostedt
2012-03-09 10:23 ` Thomas Gleixner
2012-03-09 12:51 ` Steven Rostedt
2012-03-08 19:48 ` Peter Zijlstra
2012-03-08 20:01 ` Steven Rostedt
2012-03-08 20:08 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331245213.11248.446.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox