From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758942Ab2CHWqe (ORCPT ); Thu, 8 Mar 2012 17:46:34 -0500 Received: from casper.infradead.org ([85.118.1.10]:58956 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758603Ab2CHWqd convert rfc822-to-8bit (ORCPT ); Thu, 8 Mar 2012 17:46:33 -0500 Message-ID: <1331246780.11248.451.camel@twins> Subject: Re: [PATCH] hugetlbfs: lockdep annotate root inode properly From: Peter Zijlstra To: Al Viro Cc: Andrew Morton , "Aneesh Kumar K.V" , linux-mm@kvack.org, davej@redhat.com, jboyer@redhat.com, tyhicks@canonical.com, linux-kernel@vger.kernel.org, Mimi Zohar Date: Thu, 08 Mar 2012 23:46:20 +0100 In-Reply-To: <1331246669.11248.449.camel@twins> References: <1331198116-13670-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120308130256.c7855cbd.akpm@linux-foundation.org> <20120308214425.GA23916@ZenIV.linux.org.uk> <1331246669.11248.449.camel@twins> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-03-08 at 23:44 +0100, Peter Zijlstra wrote: > On Thu, 2012-03-08 at 21:44 +0000, Al Viro wrote: > > I suspect that they right thing would be to have a way to set explicit > > nesting rules, not tied to speficic call trace. > > See might_lock() / might_lock_read(), these are used to implement > might_fault(), which is used to annotate paths that could -- but rarely > do -- fault. This will of course result in a specific trace, but if you do it early enough the trace points to your setup function, which can contain a comment explaining things.