From: Joe Perches <joe@perches.com>
To: dedekind1@gmail.com
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg
Date: Mon, 12 Mar 2012 10:11:10 -0700 [thread overview]
Message-ID: <1331572270.13200.30.camel@joe2Laptop> (raw)
In-Reply-To: <1331570150.12037.55.camel@sauron.fi.intel.com>
On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote:
> On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote:
> > I tentatively converted them to a bitmap
> > and a single jffs2_dbg(mask, fmt, ...)
> > but perhaps all of these could be deleted
> > too.
>
> I think it is better to convert them to jffs2_debug(). And I guess after
> the change the "mask" parameter will go away?
Mask would remain and perhaps become a module
variable instead of a compile #define.
What is jffs2_debug? Do you mean JFFS2_DEBUG?
My intent was to remove JFFS2_<LEVEL> defines and uses.
These #defines add
"(%d) %s" ... task_pid_nr(current), __func__
which can be added if really necessary via pr_fmt
to generic pr_<level> uses.
I am not certain of the value for generic uses of
task_pid_nr in pr_notice,pr_err, or pr_info.
Dynamic debugging has the ability to optionally add
task_pid_vnr and __func__ to pr_debug output.
next prev parent reply other threads:[~2012-03-12 17:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 23:56 [PATCH 0/4] jffs2: logging message neatening Joe Perches
2012-02-15 23:56 ` [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg Joe Perches
2012-03-05 16:30 ` Artem Bityutskiy
2012-03-05 16:56 ` Joe Perches
2012-03-09 11:53 ` Artem Bityutskiy
2012-03-09 18:49 ` Joe Perches
2012-03-12 13:12 ` Artem Bityutskiy
2012-03-12 15:33 ` Joe Perches
2012-03-12 16:35 ` Artem Bityutskiy
2012-03-12 17:11 ` Joe Perches [this message]
2012-03-13 12:39 ` Artem Bityutskiy
2012-03-13 16:34 ` Joe Perches
2012-03-14 10:54 ` Artem Bityutskiy
2012-03-09 21:59 ` [PATCH l2-mtd] jffs2: Fix build when CONFIG_JFFS2_FS_DEBUG > 0 Joe Perches
2012-03-12 13:50 ` Artem Bityutskiy
2012-02-15 23:56 ` [PATCH 2/4] jffs2: Convert printks to pr_<level> Joe Perches
2012-02-15 23:56 ` [PATCH 3/4] jffs2: Use pr_fmt and remove jffs: from formats Joe Perches
2012-02-15 23:56 ` [PATCH 4/4] jffs2: Standardize JFFS_<LEVEL> uses Joe Perches
2012-02-29 12:08 ` [PATCH 0/4] jffs2: logging message neatening Artem Bityutskiy
2012-02-29 12:12 ` Artem Bityutskiy
2012-02-29 19:02 ` Joe Perches
2012-03-01 7:36 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331572270.13200.30.camel@joe2Laptop \
--to=joe@perches.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).