From: Colin Walters <walters@verbum.org>
To: Dave Jones <davej@redhat.com>
Cc: viro@zeniv.linux.org.uk, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: suppress page allocation failure warnings from sys_listxattr
Date: Tue, 13 Mar 2012 17:33:55 -0400 [thread overview]
Message-ID: <1331674435.8346.29.camel@lenny> (raw)
In-Reply-To: <20120313182220.GA11500@redhat.com>
On Tue, 2012-03-13 at 14:22 -0400, Dave Jones wrote:
> This size is user controllable, and so it's trivial for someone to trigger a
> stream of order:4 page allocation errors.
I spent some time today struggling with an order:4 allocation failure
(my application uses CLONE_NEWNET to make an empty network stack for
software builds, and apparently one of the netfilter caches requires
this).
But is that the general principle, that we just add GFP_NOWARN if the
allocation size is trivially user controllable? I guess examples like
fs/pipe.c:pipe_set_size() agree with you, but it feels kind of like
it's papering over the problem...
next prev parent reply other threads:[~2012-03-13 21:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 18:22 suppress page allocation failure warnings from sys_listxattr Dave Jones
2012-03-13 21:33 ` Colin Walters [this message]
2012-03-27 22:51 ` Andrew Morton
2012-03-28 0:15 ` Dave Jones
2012-03-28 0:26 ` Andrew Morton
2012-03-28 7:13 ` David Rientjes
2012-03-28 4:39 ` Dave Chinner
2012-03-28 23:47 ` Andrew Morton
2012-03-29 0:54 ` Dave Jones
2012-03-29 1:10 ` Andrew Morton
2012-03-29 1:28 ` Joe Perches
2012-03-29 1:46 ` Andrew Morton
2012-03-29 1:50 ` Dave Jones
2012-03-29 2:02 ` Andrew Morton
2012-03-29 2:08 ` Dave Jones
2012-03-29 2:28 ` Andrew Morton
2012-03-29 3:00 ` Dave Jones
2012-03-29 21:09 ` Andrew Morton
2012-03-29 21:13 ` Dave Jones
2012-03-29 5:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331674435.8346.29.camel@lenny \
--to=walters@verbum.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox