From: Joe Perches <joe@perches.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL>
Date: Tue, 13 Mar 2012 19:31:51 -0700 [thread overview]
Message-ID: <1331692311.27389.27.camel@joe2Laptop> (raw)
In-Reply-To: <20120314021938.GD15379@thunk.org>
On Tue, 2012-03-13 at 22:19 -0400, Ted Ts'o wrote:
> On Tue, Mar 13, 2012 at 06:17:11PM -0700, Joe Perches wrote:
> > The patch was all apiece, every bit associated to logging output.
> > It was bundled to make it easier to apply.
> >
> > You call it junk, I call it cleanups.
>
> Changing stuff to pr_foo is ***NOISE***. It adds no value, and it
> makes it my life much, MUCH harder.
I dispute that it add no value.
pr_<foo> adds value to the dmesg output because
it can be consistently prefixed via pr_fmt.
Right now many fs ext4 messages are somewhat opaque
without any reference to what kernel subsystem produced
the message.
For instance:
fs/ext4/ialloc.c: printk(KERN_DEBUG "group %lu: stored = %d, counted = %lu\n",
This is a somewhat senseless output in dmesg without
any linkage to ext4.
Using pr_fmt and pr_debug as I sent a patch to do
instead emits in dmesg:
EXT4-fs: group: etc...
Using subsystem prefixes makes it easy and consistent to
grep dmesg.
cheers, Joe
next prev parent reply other threads:[~2012-03-14 2:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120302025554.GA13493@joana>
[not found] ` <20120301.221643.881299898523907213.davem@davemloft.net>
[not found] ` <20120301.222316.1877216960521396397.davem@davemloft.net>
[not found] ` <20120301.222604.1508242694024394849.davem@davemloft.net>
[not found] ` <1330661602.1939.13.camel@joe2Laptop>
2012-03-02 5:35 ` [PATCH] checkpatch: Add --strict tests for braces, comments and casts Joe Perches
2012-03-02 5:54 ` [PATCH] checkpatch: Add --strict test for strings split across multiple lines Joe Perches
2012-03-13 6:23 ` [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL> Joe Perches
2012-03-13 12:05 ` Ted Ts'o
2012-03-13 21:55 ` Andrew Morton
2012-03-13 22:01 ` Ted Ts'o
2012-03-13 22:03 ` Andrew Morton
2012-03-14 0:31 ` Ted Ts'o
2012-03-14 0:47 ` Joe Perches
2012-03-14 1:07 ` Ted Ts'o
2012-03-14 1:17 ` Joe Perches
2012-03-14 2:19 ` Ted Ts'o
2012-03-14 2:31 ` Joe Perches [this message]
2012-03-14 2:41 ` Ted Ts'o
2012-03-14 3:01 ` Joe Perches
2012-03-14 12:34 ` Ted Ts'o
2012-03-14 13:05 ` Joe Perches
2012-03-14 13:45 ` Ted Ts'o
2012-03-14 14:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331692311.27389.27.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox