From: Alex Shi <alex.shi@intel.com>
To: stern@rowland.harvard.edu, gregkh <gregkh@linuxfoundation.org>
Cc: sarah.a.sharp@linux.intel.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-usb <linux-usb@vger.kernel.org>
Subject: [PATCH] usb/core: skip unnecessary line IRQ request for USB3
Date: Thu, 15 Mar 2012 12:48:24 +0800 [thread overview]
Message-ID: <1331786904.2979.64.camel@debian> (raw)
USB3 requests line IRQ here but will disable it
in later driver->start function and try MSI first.
xhci_hcd 0000:02:00.0: irq 18, io mem 0xfe500000
xhci_hcd 0000:02:00.0: irq 45 for MSI/MSI-X
xhci_hcd 0000:02:00.0: irq 46 for MSI/MSI-X
So it is better to remove the redundant request here. And
save a little time in booting.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
drivers/usb/core/hcd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index e128232..5b09825 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2450,7 +2450,8 @@ int usb_add_hcd(struct usb_hcd *hcd,
/* enable irqs just before we start the controller,
* if the BIOS provides legacy PCI irqs.
*/
- if (usb_hcd_is_primary_hcd(hcd) && irqnum) {
+ if (usb_hcd_is_primary_hcd(hcd) && irqnum
+ && (hcd->driver->flags & HCD_MASK) != HCD_USB3) {
retval = usb_hcd_request_irqs(hcd, irqnum, irqflags);
if (retval)
goto err_request_irq;
--
1.7.5.1
next reply other threads:[~2012-03-15 4:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 4:48 Alex Shi [this message]
2012-03-15 6:21 ` [PATCH] usb/core: skip unnecessary line IRQ request for USB3 Xu, Andiry
2012-03-15 6:37 ` Alex Shi
2012-03-15 14:29 ` Alan Stern
2012-03-15 14:39 ` Alex Shi
2012-03-16 8:05 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331786904.2979.64.camel@debian \
--to=alex.shi@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox