From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Nanjappa, Sathisha (MCXS, Cupertino)" <sathisha.nanjappa@hp.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal.
Date: Thu, 15 Mar 2012 08:56:46 +0000 [thread overview]
Message-ID: <1331801806.2941.3.camel@dabdike> (raw)
In-Reply-To: <C8A4A375313D4E4DA64F2CB1D0490B0A44730306@G9W0735.americas.hpqcorp.net>
On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino)
wrote:
> >
> > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote:
> > > Bugzilla 42142 - mpt2sas: Number specified in wrong base
> > > https://bugzilla.kernel.org/show_bug.cgi?id=42142
> >
> > From: James Bottomley
> > Sent: Wednesday, March 14, 2012 1:34 AM
> > Do you have a better description ... like what is the user
> > visible effect of correcting the constant?
> >
>
> Does this look better:
>
> "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED
> messages do not clutter the sas_log_info messages."
Much better, thanks. The whole point of a commit message is to explain
what you're doing and why you're doing it. Just translating C to
english isn't useful because everyone who looks a kernel patches can
read C.
James
next prev parent reply other threads:[~2012-03-15 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 18:59 [PATCH] bug fix for 42142 Sathisha Nanjappa
2012-03-13 18:59 ` [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal Sathisha Nanjappa
2012-03-14 4:21 ` Nandigama, Nagalakshmi
2012-03-14 8:33 ` James Bottomley
2012-03-14 23:36 ` Nanjappa, Sathisha (MCXS, Cupertino)
2012-03-15 8:56 ` James Bottomley [this message]
2012-03-15 17:54 ` Nanjappa, Sathisha (MCXS, Cupertino)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331801806.2941.3.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathisha.nanjappa@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox