From: Peter Zijlstra <peterz@infradead.org>
To: "Liu, Chuansheng" <chuansheng.liu@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yanmin Zhang <yanmin_zhang@linux.intel.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: RE: [PATCH] Fix the race between smp_call_function and CPU booting
Date: Fri, 16 Mar 2012 10:49:24 +0100 [thread overview]
Message-ID: <1331891364.18960.221.camel@twins> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A05806B@SHSMSX101.ccr.corp.intel.com>
On Fri, 2012-03-16 at 06:24 +0000, Liu, Chuansheng wrote:
> Based on your patch, I did a little modification, how do you think of that?
> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -640,8 +640,10 @@ void set_cpu_present(unsigned int cpu, bool present)
>
> void set_cpu_online(unsigned int cpu, bool online)
> {
> - if (online)
> + if (online) {
> cpumask_set_cpu(cpu, to_cpumask(cpu_online_bits));
> + cpumask_set_cpu(cpu, to_cpumask(cpu_active_bits));
> + }
> else
> cpumask_clear_cpu(cpu, to_cpumask(cpu_online_bits));
> }
I'm thinking this lacks rationale. What was wrong, Why does this fix it.
If you can't answer that stop tinkering and start thinking.
next prev parent reply other threads:[~2012-03-16 9:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 9:27 [PATCH] Fix the race between smp_call_function and CPU booting Liu, Chuansheng
2012-03-12 9:32 ` Peter Zijlstra
2012-03-13 6:43 ` Liu, Chuansheng
2012-03-12 9:58 ` Peter Zijlstra
2012-03-13 6:46 ` Liu, Chuansheng
2012-03-13 15:57 ` Peter Zijlstra
2012-03-14 6:27 ` Liu, Chuansheng
2012-03-14 9:43 ` Peter Zijlstra
2012-03-15 0:11 ` Liu, Chuansheng
2012-03-15 10:46 ` Peter Zijlstra
2012-03-16 6:24 ` Liu, Chuansheng
2012-03-16 9:49 ` Peter Zijlstra [this message]
2012-03-19 0:58 ` Liu, Chuansheng
2012-03-19 10:03 ` Peter Zijlstra
2012-03-20 0:22 ` Liu, Chuansheng
2012-03-20 12:17 ` Peter Zijlstra
2012-03-20 13:14 ` Srivatsa S. Bhat
2012-03-20 13:41 ` Peter Zijlstra
2012-03-20 15:02 ` Srivatsa S. Bhat
2012-03-21 5:59 ` Liu, Chuansheng
2012-03-21 9:12 ` Peter Zijlstra
2012-03-21 12:25 ` Peter Zijlstra
2012-03-22 0:59 ` Liu, Chuansheng
2012-03-23 10:25 ` Peter Zijlstra
2012-03-23 11:32 ` Liu, Chuansheng
2012-03-23 12:02 ` Peter Zijlstra
2012-03-23 12:06 ` Liu, Chuansheng
2012-03-23 12:13 ` Peter Zijlstra
2012-03-23 12:21 ` Liu, Chuansheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331891364.18960.221.camel@twins \
--to=peterz@infradead.org \
--cc=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox