Re: [PATCH V2] Enhance logging for Shared Transport - TI driver

Joe Perches
2012-03-16T18:06:46Z

On Fri, 2012-03-16 at 19:58 +0200, alexandrasava18@gmail.com wrote:
> From: Alexandra Sava <alexandrasava18@gmail.com>
> * reduced verbosity
> * replaced pr_* with dev_* where possible

pr_<level> and dev_<level> formats should end in with
a "\n" newline.

> diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
[]
> @@ -19,7 +19,6 @@
> *
> */
>
> -#define pr_fmt(fmt) "(stc): " fmt

It'd be useful to keep the #define pr_fmt
perhaps as
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
for each file so that the pr_<level> uses
are prefixed by subsystem.

> @@ -122,12 +119,12 @@ void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata)
> (st_gdata->list[chnl_id]->recv
> (st_gdata->list[chnl_id]->priv_data, st_gdata->rx_skb)
> != 0)) {
> - pr_err(" proto stack %d's ->recv failed", chnl_id);
> + pr_err("proto stack %d's ->recv failed", chnl_id);

pr_err(proto stack %d's ->recv failed\n", chnl_id);

> kfree_skb(st_gdata->rx_skb);
> return;
> }
> } else {
> - pr_err(" proto stack %d's ->recv null", chnl_id);
> + pr_err("proto stack %d's ->recv null", chnl_id);

pr_err("proto stack %d's ->recv null\n", chnl_id);
etc...