From: Joe Perches <joe@perches.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH 11/11] checkpatch: Check for spin_is_locked
Date: Fri, 16 Mar 2012 12:22:35 -0700 [thread overview]
Message-ID: <1331925755.11368.14.camel@joe2Laptop> (raw)
In-Reply-To: <1331924464-18023-12-git-send-email-andi@firstfloor.org>
On Fri, 2012-03-16 at 12:01 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> spin_is_locked is usually misused. In checkpatch.pl
> - warn when it is used at all
> - error out when it is asserted on free, because that's usually broken
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +# spin_is_locked is usually misused. warn about it.
> + if ($line =~ /\bspin_is_locked\s*\(/) {
> + # BUG_ON/WARN_ON(!spin_is_locked() is generally a bug
> + if ($line =~ /(BUG_ON|WARN_ON|ASSERT)\s*\(!spin_is_locked/) {
> + ERROR("ASSERT_SPIN_IS_LOCKED",
> + "Use lockdep_assert_held() instead of asserts on !spin_is_locked\n"
> + . $herecurr);
> + } else {
> + WARN("SPIN_IS_LOCKED",
> + "spin_is_locked is very rarely correctly used. Please reconsider\n"
> + . $herecurr)
> + }
> + }
> +
I suggest you use a single --ignore string of
"SPIN_IS_LOCKED" instead of different ones.
Grammar might be improved in the WARN. Maybe:
"Using spin_is_locked() is generally wrong. See [foo documentation]\n"
Also, like what was done for yield(), perhaps
some kernel-doc content would be useful.
See -next commit 8e3fabfde445a872c8aec2296846badf24d7c8b4
next prev parent reply other threads:[~2012-03-16 19:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 19:00 Tree sweep for spin_is_locked misuses and start warning about it Andi Kleen
2012-03-16 19:00 ` [PATCH 01/11] block: use lockdep_assert_held for queue locking Andi Kleen
2012-03-16 19:00 ` [PATCH 02/11] sgi-xp: Use lockdep_assert_held Andi Kleen
2012-03-16 19:11 ` Robin Holt
2012-03-16 19:00 ` [PATCH 03/11] ada152x: Remove broken usage of spin_is_locked Andi Kleen
2012-03-16 19:00 ` [PATCH 04/11] staging/zmem: Use lockdep_assert_held instead " Andi Kleen
2012-03-16 19:00 ` [PATCH 05/11] XFS: Fix lock ASSERT on UP Andi Kleen
2012-03-19 22:47 ` Dave Chinner
2012-03-20 2:28 ` Andi Kleen
2012-03-21 0:44 ` Dave Chinner
2012-03-16 19:00 ` [PATCH 06/11] huge-memory: Use lockdep_assert_held Andi Kleen
2012-03-16 19:44 ` Andrea Arcangeli
2012-03-16 21:18 ` Hugh Dickins
2012-03-16 19:01 ` [PATCH 07/11] futex: Use lockdep_assert_held() for lock checking Andi Kleen
2012-03-16 19:01 ` [PATCH 08/11] irda: remove spin_is_locked Andi Kleen
2012-03-16 19:01 ` [PATCH 09/11] usb: gadget: f_fs: Remove lock is held before freeing checks Andi Kleen
2012-03-16 19:01 ` [PATCH 10/11] smsc911x: Use lockdep_assert_held instead of home grown buggy construct Andi Kleen
2012-03-16 19:01 ` [PATCH 11/11] checkpatch: Check for spin_is_locked Andi Kleen
2012-03-16 19:22 ` Joe Perches [this message]
2012-03-16 20:14 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331925755.11368.14.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox