From: Peter Zijlstra <peterz@infradead.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: cpu_active vs pcrypt & padata
Date: Sat, 17 Mar 2012 22:00:34 +0100 [thread overview]
Message-ID: <1332018034.18960.247.camel@twins> (raw)
In-Reply-To: <20120316104409.GP15404@secunet.com>
On Fri, 2012-03-16 at 11:44 +0100, Steffen Klassert wrote:
> Hi.
>
> On Fri, Mar 16, 2012 at 11:13:08AM +0100, Peter Zijlstra wrote:
> > Hi Steffen,
> >
> > I found cpu_active usage in crypto/pcrypt.c and was wondering what
> > that's doing there. I would really like to contain that thing to as
> > narrow a piece of kernel as I possible can (sched/cpuset/hotplug) but it
> > appears to be spreading.
>
> pcrypt uses cpu_active to tell padata which cpuset it whishes
> to use for parallelization. I could try to push the cpumask
> handling down to padata if you want to limit this to the core
> kernel.
/me more confused now.. cpu_active isn't in any way shape or form
related to cpusets.
> > Also, wth is all this kernel/padata.c stuff? There's next to no useful
> > comment in there and the only consumer seems to be pcrypt, does that
> > really need to be in kernel/ ?
>
> The padata code is generic and not limited to crypto, you can find
> a documentation at Documentation/padata.txt.
Would be nice to have a short blurb in kernel/padata.c with a reference
to that Documentation stuff for more in-depth bits.
next prev parent reply other threads:[~2012-03-17 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 10:13 cpu_active vs pcrypt & padata Peter Zijlstra
2012-03-16 10:16 ` David Miller
2012-03-16 10:20 ` Peter Zijlstra
2012-03-16 10:32 ` David Miller
2012-03-16 10:42 ` Peter Zijlstra
2012-03-16 10:44 ` Steffen Klassert
2012-03-17 21:00 ` Peter Zijlstra [this message]
2012-03-20 7:44 ` Steffen Klassert
2012-03-16 13:15 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332018034.18960.247.camel@twins \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steffen.klassert@secunet.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox