Re: [RFC][PATCH 00/26] sched/numa

Peter Zijlstra
2012-03-22T09:46:18Z

> I was going to try and test this on power, but it fails to build:
>
> mm/filemap_xip.c: In function ‘__xip_unmap’:
> mm/filemap_xip.c:199: error: implicit declaration of function
> ‘numa_add_vma_counter’

Add:

#include <linux/mempolicy.h>

to that file and it should build.

> > [26/26] sched, numa: A few debug bits
>
> introduced a new warning:
>
> kernel/sched/numa.c: In function ‘process_cpu_runtime’:
> kernel/sched/numa.c:210: warning: format ‘%lu’ expects type ‘long
> unsigned int’, but argument 3 has type ‘u64’
> kernel/sched/numa.c:210: warning: format ‘%lu’ expects type ‘long
> unsigned int’, but argument 4 has type ‘u64’

Yeah, that's a known trainwreck, some archs define u64 as unsigned long
others as unsigned long long, so whatever you write: %ul or %ull is
wrong and I can't be arsed to add an explict cast since its all debug
bits that won't ever make it in anyway.