Re: [RFC][PATCH 02/26] mm, mpol: Remove NUMA_INTERLEAVE_HIT

Peter Zijlstra
2012-07-06T15:01:42Z

On Fri, 2012-07-06 at 23:54 +0900, Kyungmin Park wrote:
> > static struct zonelist *policy_zonelist(gfp_t gfp, struct mempolicy *policy,
> > int nd)
> > {
> > switch (policy->mode) {
> > + case MPOL_INTERLEAVE:
> > + nd = interleave_nodes(policy);
> Jut nitpick,
> Original code also uses the 'unsigned nid' but now it assigned
> 'unsigned nid' to 'int nd' at here. does it right?

node id is generally signed, we use -1 as a special value indicating no
node preference in a number of places. Not sure why it was unsigned
here. Also I think even SGI isn't anywhere near 2^31 nodes.