From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, vgoyal@redhat.com
Cc: linux-kernel@vger.kernel.org, ctalbott@google.com, rni@google.com
Subject: [PATCHSET] block: remove ioc_*_changed()
Date: Mon, 19 Mar 2012 15:10:55 -0700 [thread overview]
Message-ID: <1332195059-2750-1-git-send-email-tj@kernel.org> (raw)
Hello, guys.
The changed notification used by cfq is rather odd. cfq caches the
associated cfqqs per cic and uses the changed notification to expire
those lookup caches.
The explicit notification mechanism might make sense if determining
whether the current cache is up-to-date is difficult or expensive;
however, that isn't the case here. Determining whether ioprio or
cgroup has changed is straight-forward and inexpensive.
This patchset updates cfq to so that it remembers the current ioprio
and blkcg in the cic and determines whether cfqq's need to be reset
without using the changed notification and drops the changed
notification code.
0001-blkcg-add-blkcg-id.patch
0002-cfq-pass-around-cfq_io_cq-instead-of-io_context.patch
0003-cfq-don-t-use-icq_get_changed.patch
0004-block-remove-ioc_-_changed.patch
0001 adds unique u64 id to each blkcg so that policies can tell
whether the associated blkcg has changed.
0002 makes cfq pass around cic internally instead of ioc. This is a
cleanup in itself and necessary for the next patch.
0003 updates cfq to not use changed notification.
0004 removes code implementing changed notification.
This patchset is on top of
block/for-3.4/core 671058fb2a2aac4e70f01b316b06bc59b98bd138
+ [1] blkcg: fix percpu stat allocation and remove stats_lock, take#2
and available in the following git branch
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git blk-ioc-remove-changed
Thanks.
block/blk-cgroup.c | 22 +----------
block/blk-cgroup.h | 3 +
block/blk-ioc.c | 68 ----------------------------------
block/cfq-iosched.c | 92 ++++++++++++++++++++++++++--------------------
fs/ioprio.c | 2 -
include/linux/iocontext.h | 7 ---
include/linux/ioprio.h | 22 ++---------
7 files changed, 64 insertions(+), 152 deletions(-)
--
tejun
[1] http://thread.gmane.org/gmane.linux.kernel/1263989
next reply other threads:[~2012-03-19 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 22:10 Tejun Heo [this message]
2012-03-19 22:10 ` [PATCH 1/4] blkcg: add blkcg->id Tejun Heo
2012-03-19 22:10 ` [PATCH 2/4] cfq: pass around cfq_io_cq instead of io_context Tejun Heo
2012-03-19 22:10 ` [PATCH 3/4] cfq: don't use icq_get_changed() Tejun Heo
2012-03-19 22:10 ` [PATCH 4/4] block: remove ioc_*_changed() Tejun Heo
2012-03-20 11:49 ` [PATCHSET] " Jens Axboe
2012-03-20 15:51 ` Vivek Goyal
2012-03-20 15:53 ` Tejun Heo
2012-03-20 16:00 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332195059-2750-1-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).