From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 1/3] perf, tool: Fix various casting issues for 32 bits
Date: Tue, 20 Mar 2012 19:15:39 +0100 [thread overview]
Message-ID: <1332267341-26338-2-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1332267341-26338-1-git-send-email-jolsa@redhat.com>
- util/parse-events.c(parse_events_add_breakpoint)
need to use unsigned long instead of u64, otherwise
we get following gcc error on 32 bits:
error: cast from pointer to integer of different size
- util/header.c(print_event_desc)
cannot retype to signed type, otherwise we get following
gcc error on 32 bits:
error: comparison between signed and unsigned integer expressions
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
| 2 +-
tools/perf/util/parse-events.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index fcd9cf3..4c7c2d7 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1177,7 +1177,7 @@ static void print_event_desc(struct perf_header *ph, int fd, FILE *fp)
goto error;
msz = sizeof(attr);
- if (sz < (ssize_t)msz)
+ if (sz < msz)
msz = sz;
for (i = 0 ; i < nre; i++) {
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 201b40f..f542a63 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -569,7 +569,7 @@ int parse_events_add_breakpoint(struct list_head *list, int *idx,
char name[MAX_NAME_LEN];
memset(&attr, 0, sizeof(attr));
- attr.bp_addr = (u64) ptr;
+ attr.bp_addr = (unsigned long) ptr;
if (parse_breakpoint_type(type, &attr))
return -EINVAL;
--
1.7.7.6
next prev parent reply other threads:[~2012-03-20 18:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 18:15 [RFC 0/3] perf tool: Add new event group management Jiri Olsa
2012-03-20 18:15 ` Jiri Olsa [this message]
2012-03-23 8:29 ` [tip:perf/urgent] perf tools: Fix various casting issues for 32 bits tip-bot for Jiri Olsa
2012-03-20 18:15 ` [PATCH 2/3] perf, tool: Fix modifier to be applied on correct events Jiri Olsa
2012-03-23 8:30 ` [tip:perf/urgent] perf tools: " tip-bot for Jiri Olsa
2012-03-20 18:15 ` [PATCH 3/3] perf, tool: Add new event group management Jiri Olsa
2012-03-20 18:44 ` Peter Zijlstra
2012-03-20 20:46 ` Ingo Molnar
2012-03-20 22:18 ` Arnaldo Carvalho de Melo
2012-03-21 9:15 ` Peter Zijlstra
2012-03-21 9:52 ` Ingo Molnar
2012-03-21 11:54 ` Peter Zijlstra
2012-03-21 12:15 ` Ingo Molnar
2012-03-21 15:13 ` Arnaldo Carvalho de Melo
2012-03-22 7:56 ` Ingo Molnar
2012-03-22 12:41 ` Arnaldo Carvalho de Melo
2012-03-22 13:54 ` Ingo Molnar
2012-03-22 14:07 ` Jiri Olsa
2012-03-20 22:36 ` Jiri Olsa
2012-03-21 11:54 ` Peter Zijlstra
2012-03-21 10:42 ` Jiri Olsa
2012-03-21 15:11 ` Arnaldo Carvalho de Melo
2012-03-21 22:27 ` Jiri Olsa
2012-03-22 12:40 ` Arnaldo Carvalho de Melo
2012-04-10 13:19 ` Jiri Olsa
2012-03-20 20:08 ` Arnaldo Carvalho de Melo
2012-03-20 22:16 ` Jiri Olsa
2012-03-21 2:12 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332267341-26338-2-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).