From: Joe Perches <joe@perches.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines
Date: Wed, 21 Mar 2012 05:11:23 -0700 [thread overview]
Message-ID: <1332331883.29403.31.camel@joe2Laptop> (raw)
In-Reply-To: <20120321060544.GA2831@leaf>
On Tue, 2012-03-20 at 23:05 -0700, Josh Triplett wrote:
> On Tue, Mar 20, 2012 at 09:35:58PM -0700, Joe Perches wrote:
> > One improvement might be to check for a line continuation \
> > on $prevline and still produce a warning in that case.
>
> I'd suggest doing that one as a separate check, "unnecessary line
> continuation", which should flag any use of a line continuation other
> than with a preprocessor directive. I don't think combining that with
> the wrapped-string check makes sense.
What I suggested is for a case in a #define:
#define subsystem_printk(subsystem, level, format, ...) \
netdev_printk(level, (subsystem)->dev, "Some partial format " \
"continued on another line" format, \
##__VA_ARGS__)
where it's necessary to use line continuations but rewrapping like:
#define subsystem_printk(subsystem, level, format, ...) \
netdev_printk(level, (subsystem)->dev, \
"A coalesced format on a single line" format, \
##__VA_ARGS__)
might improve it.
Anyway:
Acked-by: Joe Perches <joe@perches.com>
next prev parent reply other threads:[~2012-03-21 12:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 21:06 [PATCH] checkpatch: Check for quoted strings broken across lines Josh Triplett
2012-03-21 1:24 ` Joe Perches
2012-03-21 4:28 ` Josh Triplett
2012-03-21 4:35 ` Joe Perches
2012-03-21 6:05 ` Josh Triplett
2012-03-21 12:11 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-03 5:27 Josh Triplett
2012-02-03 5:38 ` Joe Perches
2012-02-03 8:55 ` Josh Triplett
2012-02-03 6:34 ` Josh Triplett
2012-02-02 20:06 Josh Triplett
2012-02-02 20:22 ` Nick Bowler
2012-02-02 21:16 ` Josh Triplett
2012-02-02 22:08 ` Nick Bowler
2012-02-03 1:31 ` Josh Triplett
2012-02-02 21:29 ` Jesper Juhl
2012-02-02 21:34 ` Joe Perches
2012-02-02 22:02 ` Josh Triplett
2012-02-02 20:36 ` Joe Perches
2012-02-02 21:28 ` Josh Triplett
2012-02-02 21:32 ` Joe Perches
2012-02-02 22:36 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332331883.29403.31.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox