[PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[Axel Lin]

Do not assume the gpio regulator states map is sorted in any order.
This patch ensures we always set the smallest voltage/current that falls within
the specified range.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/gpio-regulator.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 42e1cb1..b728b36 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -105,15 +105,15 @@ static int gpio_regulator_set_value(struct regulator_dev *dev,
 					int min, int max)
 {
 	struct gpio_regulator_data *data = rdev_get_drvdata(dev);
-	int ptr, target, state;
+	int ptr, target, state, best_val = INT_MAX;
 
-	target = -1;
 	for (ptr = 0; ptr < data->nr_states; ptr++)
-		if (data->states[ptr].value >= min &&
+		if (data->states[ptr].value < best_val &&
+		    data->states[ptr].value >= min &&
 		    data->states[ptr].value <= max)
 			target = data->states[ptr].gpios;
 
-	if (target < 0)
+	if (best_val == INT_MAX)
 		return -EINVAL;
 
 	for (ptr = 0; ptr < data->nr_gpios; ptr++) {
-- 
1.7.5.4

Re: [PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[Heiko Stübner]

Am Donnerstag, 22. März 2012, 07:08:04 schrieb Axel Lin:
> Do not assume the gpio regulator states map is sorted in any order.
> This patch ensures we always set the smallest voltage/current that falls
> within the specified range.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

nice addition, thanks

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/regulator/gpio-regulator.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/regulator/gpio-regulator.c
> b/drivers/regulator/gpio-regulator.c index 42e1cb1..b728b36 100644
> --- a/drivers/regulator/gpio-regulator.c
> +++ b/drivers/regulator/gpio-regulator.c
> @@ -105,15 +105,15 @@ static int gpio_regulator_set_value(struct
> regulator_dev *dev, int min, int max)
>  {
>  	struct gpio_regulator_data *data = rdev_get_drvdata(dev);
> -	int ptr, target, state;
> +	int ptr, target, state, best_val = INT_MAX;
> 
> -	target = -1;
>  	for (ptr = 0; ptr < data->nr_states; ptr++)
> -		if (data->states[ptr].value >= min &&
> +		if (data->states[ptr].value < best_val &&
> +		    data->states[ptr].value >= min &&
>  		    data->states[ptr].value <= max)
>  			target = data->states[ptr].gpios;
> 
> -	if (target < 0)
> +	if (best_val == INT_MAX)
>  		return -EINVAL;
> 
>  	for (ptr = 0; ptr < data->nr_gpios; ptr++) {

Re: [PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

On Thu, Mar 22, 2012 at 02:08:04PM +0800, Axel Lin wrote:
> Do not assume the gpio regulator states map is sorted in any order.
> This patch ensures we always set the smallest voltage/current that falls within
> the specified range.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[Yi Zhang]

Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes:

> 
> On Thu, Mar 22, 2012 at 02:08:04PM +0800, Axel Lin wrote:
> > Do not assume the gpio regulator states map is sorted in any order.
> > This patch ensures we always set the smallest voltage/current that falls 
within
> > the specified range.
> 
> Applied, thanks.
> 

 	struct gpio_regulator_data *data = rdev_get_drvdata(dev);
-	int ptr, target, state;
+	int ptr, target, state, best_val = INT_MAX;

-	target = -1;
 	for (ptr = 0; ptr < data->nr_states; ptr++)
-		if (data->states[ptr].value >= min &&
+		if (data->states[ptr].value < best_val &&
+		    data->states[ptr].value >= min &&
 		    data->states[ptr].value <= max)
 			target = data->states[ptr].gpios;

-	if (target < 0)
+	if (best_val == INT_MAX)

Here seems something wrong, for best_val is always INT_MAX. From the discussion 
above, maybe best_val is should be reassigned in the for loop.
It may be like as the following:

-       for (ptr = 0; ptr < data->nr_states; ptr++)
+       for (ptr = 0; ptr < data->nr_states; ptr++) {
                if (data->states[ptr].value < best_val &&
                    data->states[ptr].value >= min &&
-                   data->states[ptr].value <= max)
+                   data->states[ptr].value <= max) {
                        target = data->states[ptr].gpios;
+                       best_val = target;
+       }

What do you think? thanks;