From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756645Ab2C0WFU (ORCPT ); Tue, 27 Mar 2012 18:05:20 -0400 Received: from casper.infradead.org ([85.118.1.10]:58190 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754191Ab2C0WFT convert rfc822-to-8bit (ORCPT ); Tue, 27 Mar 2012 18:05:19 -0400 Message-ID: <1332885905.2528.3.camel@twins> Subject: Re: [PATCH] perf, p4: Add format attributes From: Peter Zijlstra To: Cyrill Gorcunov Cc: Ingo Molnar , Jiri Olsa , Lin Ming , rostedt , linux-kernel , Stephane Eranian Date: Wed, 28 Mar 2012 00:05:05 +0200 In-Reply-To: <20120327220343.GG16537@moon> References: <1332859842.16159.227.camel@twins> <20120327145728.GE11875@moon> <1332860759.16159.233.camel@twins> <20120327151250.GG11875@moon> <20120327220343.GG16537@moon> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-03-28 at 02:03 +0400, Cyrill Gorcunov wrote: > On Tue, Mar 27, 2012 at 07:12:50PM +0400, Cyrill Gorcunov wrote: > > > > Ah, I see thanks for the reference, Peter! > > > > > I've still not actually read the P4-PMU specs, so I don't know if > > > there's anything more convenient we can do on P4. If there's a > > > better/more useful format representation possible, don't hesitate to > > > send a patch! :-) > > > > Sure, I'll try to find some time tonight to read this brand > > new stuff. And if I find something -- will send out. At moment > > your patch should be more than enough ;) > > Hi, Peter, sorry for delay, > > after looking some more I think ht bit might be dropped from > the format, it's used internally by the kernel in attmept to > eliminate redundant msr poking if new event runs on the same > thread as previous one, and it's always cleared before real > write to msr happens, which means user-space might set or > clear it, but it never be considered by the kernel. > > (still my earlier reviewed-by is valid because this ht bit > is harmless ;) So does that make escr:32-62 or should that become 32-63 ?