From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759687Ab2C2QrG (ORCPT ); Thu, 29 Mar 2012 12:47:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61096 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759599Ab2C2Qpx (ORCPT ); Thu, 29 Mar 2012 12:45:53 -0400 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Linux Edac Mailing List , Linux Kernel Mailing List Subject: [PATCH 08/13] i5400_edac: improve debug messages to better represent the filled memory Date: Thu, 29 Mar 2012 13:45:41 -0300 Message-Id: <1333039546-5590-9-git-send-email-mchehab@redhat.com> In-Reply-To: <1333039546-5590-1-git-send-email-mchehab@redhat.com> References: <1333039546-5590-1-git-send-email-mchehab@redhat.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Improves the debug output message, in order to better represent the memory controller hierarchy, when outputing the debug messages. No functional changes when debug is disabled. Signed-off-by: Mauro Carvalho Chehab --- drivers/edac/i5400_edac.c | 15 ++++++++++++++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/drivers/edac/i5400_edac.c b/drivers/edac/i5400_edac.c index 3aa2a1e..5debda9 100644 --- a/drivers/edac/i5400_edac.c +++ b/drivers/edac/i5400_edac.c @@ -963,7 +963,7 @@ static void calculate_dimm_size(struct i5400_pvt *pvt) int dimm, max_dimms; char *p, *mem_buffer; int space, n; - int channel; + int channel, branch; /* ================= Generate some debug output ================= */ space = PAGE_SIZE; @@ -1028,6 +1028,19 @@ static void calculate_dimm_size(struct i5400_pvt *pvt) space -= n; } + space -= n; + debugf2("%s\n", mem_buffer); + p = mem_buffer; + space = PAGE_SIZE; + + n = snprintf(p, space, " "); + p += n; + for (branch = 0; branch < MAX_BRANCHES; branch++) { + n = snprintf(p, space, " branch %d | ", branch); + p += n; + space -= n; + } + /* output the last message and free buffer */ debugf2("%s\n", mem_buffer); kfree(mem_buffer); -- 1.7.8