From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: dhowells@redhat.com
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH 09/11] firewire: restore the device.h include in linux/firewire.h
Date: Sun, 1 Apr 2012 16:38:45 -0400 [thread overview]
Message-ID: <1333312727-11428-10-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1333312727-11428-1-git-send-email-paul.gortmaker@windriver.com>
Commit 313162d0b83836e2f57e51b9b8650fb4b9c396ea
"device.h: audit and cleanup users in main include dir"
exchanged an include <linux/device.h> for a struct *device
but in actuality I misread this file when creating 313162d
and it should have remained an include.
There were no build regressions since all consumers were
already getting device.h anyway, but make it right regardless.
Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
include/linux/firewire.h | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/include/linux/firewire.h b/include/linux/firewire.h
index 4db7b68..cdc9b71 100644
--- a/include/linux/firewire.h
+++ b/include/linux/firewire.h
@@ -2,6 +2,7 @@
#define _LINUX_FIREWIRE_H
#include <linux/completion.h>
+#include <linux/device.h>
#include <linux/dma-mapping.h>
#include <linux/kernel.h>
#include <linux/kref.h>
@@ -64,8 +65,6 @@
#define CSR_MODEL 0x17
#define CSR_DIRECTORY_ID 0x20
-struct device;
-
struct fw_csr_iterator {
const u32 *p;
const u32 *end;
--
1.7.9.1
next prev parent reply other threads:[~2012-04-01 20:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 20:38 [PATCH 00/11] Fix up more asm/system.h fallout Paul Gortmaker
2012-04-01 20:38 ` [PATCH 01/11] irq_work: fix compile failure on MIPS from system.h split Paul Gortmaker
2012-04-01 20:38 ` [PATCH 02/11] ARM: mach-msm: fix compile fail from system.h fallout Paul Gortmaker
2012-04-02 21:16 ` David Brown
2012-04-01 20:38 ` [PATCH 03/11] avr32: fix nop compile fails from system.h split up Paul Gortmaker
2012-04-01 20:38 ` [PATCH 04/11] avr32: fix build failures from mis-naming of atmel_nand.h Paul Gortmaker
2012-04-01 20:38 ` [PATCH 05/11] blackfin: fix cmpxchg build fails from system.h fallout Paul Gortmaker
2012-04-01 20:38 ` [PATCH 06/11] parisc: fix missing cmpxchg file error from system.h split Paul Gortmaker
2012-04-01 20:38 ` [PATCH 07/11] sh: fix several build failures from system.h fallout Paul Gortmaker
2012-04-02 1:00 ` Paul Mundt
2012-04-02 18:15 ` Paul Gortmaker
2012-04-02 23:57 ` Stephen Rothwell
2012-04-05 2:46 ` Paul Gortmaker
2012-04-05 2:49 ` Paul Gortmaker
2012-04-05 15:15 ` Paul Mundt
2012-04-06 6:40 ` linux-next: sh tree (Was:Re: [PATCH 07/11] sh: fix several build failures from system.h fallout) Stephen Rothwell
2012-04-01 20:38 ` [PATCH 08/11] frv: fix warnings in mb93090-mb00/pci-dma.c about implicit EXPORT_SYMBOL Paul Gortmaker
2012-04-01 20:38 ` Paul Gortmaker [this message]
2012-04-01 20:38 ` [PATCH 10/11] tile: fix multiple build failures from system.h dismantle Paul Gortmaker
2012-04-01 20:38 ` [PATCH 11/11] asm-generic: add linux/types.h to cmpxchg.h Paul Gortmaker
2012-04-06 6:28 ` Jonas Bonn
2012-04-02 0:03 ` [PATCH 00/11] Fix up more asm/system.h fallout Stephen Rothwell
2012-04-02 5:30 ` David Howells
2012-04-02 5:43 ` [PATCH 08/11] frv: fix warnings in mb93090-mb00/pci-dma.c about implicit EXPORT_SYMBOL David Howells
2012-04-02 5:44 ` [PATCH 02/11] ARM: mach-msm: fix compile fail from system.h fallout David Howells
2012-04-02 5:45 ` [PATCH 01/11] irq_work: fix compile failure on MIPS from system.h split David Howells
2012-04-02 5:47 ` [PATCH 03/11] avr32: fix nop compile fails from system.h split up David Howells
2012-04-02 19:11 ` Paul Gortmaker
2012-04-02 5:49 ` [PATCH 05/11] blackfin: fix cmpxchg build fails from system.h fallout David Howells
2012-04-02 5:50 ` [PATCH 06/11] parisc: fix missing cmpxchg file error from system.h split David Howells
2012-04-02 5:52 ` [PATCH 10/11] tile: fix multiple build failures from system.h dismantle David Howells
2012-04-02 15:59 ` Chris Metcalf
2012-04-02 18:05 ` Paul Gortmaker
2012-04-02 5:53 ` [PATCH 11/11] asm-generic: add linux/types.h to cmpxchg.h David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333312727-11428-10-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).