From: Joe Perches <joe@perches.com>
To: Kay Sievers <kay@vrfy.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] printk(): add KERN_CONT where needed
Date: Mon, 02 Apr 2012 20:47:45 -0700 [thread overview]
Message-ID: <1333424865.26079.9.camel@joe2Laptop> (raw)
In-Reply-To: <CAPXgP12jX37GLgMJQuDYEi6q5A2Ma3d+e+_sNkFVdYfwsdMrtQ@mail.gmail.com>
On Tue, 2012-04-03 at 05:00 +0200, Kay Sievers wrote:
> On Tue, Apr 3, 2012 at 04:36, Joe Perches <joe@perches.com> wrote:
> > A couple of other trivial comments:
> > It's better to try to coalesce multiple printks(KERN_CONT
> > (perhaps it's better to use pr_cont instead too)
> > Branches with the same printks should be hoisted where
> > possible.
> Sure, please send patches for anything that is more appropriate to use here.
> I did not want to change any logic which needs to be tested. I just
> trivially added the obviously missing prefix, which solved the
> problem, and which could be applied right away.
I think you should do it "right" rather than add
trivial markers.
next prev parent reply other threads:[~2012-04-03 3:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 1:18 [PATCH] printk(): add KERN_CONT where needed Kay Sievers
2012-04-03 2:36 ` Joe Perches
2012-04-03 3:00 ` Kay Sievers
2012-04-03 3:03 ` Joe Perches
2012-04-03 3:47 ` Joe Perches [this message]
2012-04-03 10:30 ` Kay Sievers
2012-04-03 14:32 ` Joe Perches
2012-04-03 15:50 ` Kay Sievers
2012-04-03 16:05 ` Joe Perches
2012-04-03 16:11 ` Kay Sievers
2012-04-03 16:16 ` Joe Perches
2012-04-03 16:20 ` Kay Sievers
2012-04-03 16:27 ` Joe Perches
2012-04-09 23:08 ` Andrew Morton
2012-04-09 23:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333424865.26079.9.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=kay@vrfy.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox