From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754758Ab2DCPUN (ORCPT ); Tue, 3 Apr 2012 11:20:13 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:55907 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752879Ab2DCPUM (ORCPT ); Tue, 3 Apr 2012 11:20:12 -0400 Message-ID: <1333466400.4720.1.camel@phoenix> Subject: [PATCH 1/2] regulator: max8997: Use simple equation to get selector From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Kyungmin Park , MyungJoo Ham , Liam Girdwood , Mark Brown Date: Tue, 03 Apr 2012 23:20:00 +0800 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's more efficient to get the best selector by simple equation. Signed-off-by: Axel Lin --- drivers/regulator/max8997.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c index 6e7beee..de752da 100644 --- a/drivers/regulator/max8997.c +++ b/drivers/regulator/max8997.c @@ -416,7 +416,7 @@ static inline int max8997_get_voltage_proper_val( const struct voltage_map_desc *desc, int min_vol, int max_vol) { - int i = 0; + int i; if (desc == NULL) return -EINVAL; @@ -424,9 +424,10 @@ static inline int max8997_get_voltage_proper_val( if (max_vol < desc->min || min_vol > desc->max) return -EINVAL; - while (desc->min + desc->step * i < min_vol && - desc->min + desc->step * i < desc->max) - i++; + if (min_vol < desc->min) + min_vol = desc->min; + + i = DIV_ROUND_UP(min_vol - desc->min, desc->step); if (desc->min + desc->step * i > max_vol) return -EINVAL; -- 1.7.5.4