* [PATCH] regulator: Fix rc5t583_regulator_probe error handling
@ 2012-04-04 11:52 Axel Lin
2012-04-04 12:07 ` Laxman Dewangan
2012-04-04 21:14 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-04-04 11:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Laxman Dewangan, Liam Girdwood, Mark Brown
1. regulator_register returns ERR_PTR on error, thus use IS_ERR to check the
return value.
2. Fix off-by-one for unregistering the registered regulator.
Current code does not unregister regs[0].rdev in clean_exit.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/rc5t583-regulator.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/rc5t583-regulator.c b/drivers/regulator/rc5t583-regulator.c
index 37732f7..cac8a2a 100644
--- a/drivers/regulator/rc5t583-regulator.c
+++ b/drivers/regulator/rc5t583-regulator.c
@@ -312,7 +312,7 @@ static int __devinit rc5t583_regulator_probe(struct platform_device *pdev)
skip_ext_pwr_config:
rdev = regulator_register(&ri->desc, &pdev->dev,
reg_data, reg, NULL);
- if (IS_ERR_OR_NULL(rdev)) {
+ if (IS_ERR(rdev)) {
dev_err(&pdev->dev, "Failed to register regulator %s\n",
ri->desc.name);
ret = PTR_ERR(rdev);
@@ -324,7 +324,7 @@ skip_ext_pwr_config:
return 0;
clean_exit:
- while (--id > 0)
+ while (--id >= 0)
regulator_unregister(regs[id].rdev);
return ret;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: Fix rc5t583_regulator_probe error handling
2012-04-04 11:52 [PATCH] regulator: Fix rc5t583_regulator_probe error handling Axel Lin
@ 2012-04-04 12:07 ` Laxman Dewangan
2012-04-04 21:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2012-04-04 12:07 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown
On Wednesday 04 April 2012 05:22 PM, Axel Lin wrote:
> 1. regulator_register returns ERR_PTR on error, thus use IS_ERR to check the
> return value.
> 2. Fix off-by-one for unregistering the registered regulator.
> Current code does not unregister regs[0].rdev in clean_exit.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: Fix rc5t583_regulator_probe error handling
2012-04-04 11:52 [PATCH] regulator: Fix rc5t583_regulator_probe error handling Axel Lin
2012-04-04 12:07 ` Laxman Dewangan
@ 2012-04-04 21:14 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-04-04 21:14 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Laxman Dewangan, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On Wed, Apr 04, 2012 at 07:52:35PM +0800, Axel Lin wrote:
> 1. regulator_register returns ERR_PTR on error, thus use IS_ERR to check the
> return value.
> 2. Fix off-by-one for unregistering the registered regulator.
> Current code does not unregister regs[0].rdev in clean_exit.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-04 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-04 11:52 [PATCH] regulator: Fix rc5t583_regulator_probe error handling Axel Lin
2012-04-04 12:07 ` Laxman Dewangan
2012-04-04 21:14 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox